[DI] remove useless condition around unset

Tobion · Tobion · commit 478375d66424 · 2015-11-26T18:53:25.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -312,10 +312,7 @@ public function get($id, $invalidBehavior = self::EXCEPTION_ON_INVALID_REFERENCE
                 $service = $this->$method();
             } catch (\Exception $e) {
                 unset($this->loading[$id]);
-
-                if (array_key_exists($id, $this->services)) {
-                    unset($this->services[$id]);
-                }
+                unset($this->services[$id]);
 
                 if ($e instanceof InactiveScopeException && self::EXCEPTION_ON_INVALID_REFERENCE !== $invalidBehavior) {
                     return;
diff --git a/src/Symfony/Component/DependencyInjection/Definition.php b/src/Symfony/Component/DependencyInjection/Definition.php
@@ -409,9 +409,7 @@ public function hasTag($name)
      */
     public function clearTag($name)
     {
-        if (isset($this->tags[$name])) {
-            unset($this->tags[$name]);
-        }
+        unset($this->tags[$name]);
 
         return $this;
     }

Original file line number	Diff line number	Diff line change
`@@ -409,9 +409,7 @@ public function hasTag($name)`
`409`	`409`	`*/`
`410`	`410`	`public function clearTag($name)`
`411`	`411`	`{`
`412`		`- if (isset($this->tags[$name])) {`
`413`		`- unset($this->tags[$name]);`
`414`		`- }`
	`412`	`+ unset($this->tags[$name]);`
`415`	`413`
`416`	`414`	`return $this;`
`417`	`415`	`}`