bug #32818 [HttpKernel] Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler (Arman-Hosseini)

fabpot · fabpot · commit 47a87849c076 · 2019-09-08T09:16:45.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler | Q | A | ------------- | --- | Branch? | >= 3.4  | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #32444  | License | MIT | Doc PR | N/A  I had this problem and I noticed that an issue had already been registered. So I registered the pull request. Commits ------- 9ed5f03 Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler
diff --git a/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php b/src/Symfony/Component/HttpKernel/Debug/FileLinkFormatter.php
@@ -106,7 +106,7 @@ private function getFileLinkFormat()
                 }
 
                 return [
-                    $request->getSchemeAndHttpHost().$request->getBasePath().$this->urlFormat,
+                    $request->getSchemeAndHttpHost().$this->urlFormat,
                     $this->baseDir.\DIRECTORY_SEPARATOR, '',
                 ];
             }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ private function getFileLinkFormat()`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`return [`
`109`		`- $request->getSchemeAndHttpHost().$request->getBasePath().$this->urlFormat,`
	`109`	`+ $request->getSchemeAndHttpHost().$this->urlFormat,`
`110`	`110`	`$this->baseDir.\DIRECTORY_SEPARATOR, '',`
`111`	`111`	`];`
`112`	`112`	`}`