[RateLimiter] Allow configuration value "no_limit"

Nyholm · Nyholm · commit 47af76f9a798 · 2020-10-21T23:20:40.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -1846,14 +1846,14 @@ private function addRateLimiterSection(ArrayNodeDefinition $rootNode)
                                     ->enumNode('strategy')
                                         ->info('The rate limiting algorithm to use for this rate')
                                         ->isRequired()
-                                        ->values(['fixed_window', 'token_bucket', 'sliding_window'])
+                                        ->values(['fixed_window', 'token_bucket', 'sliding_window', 'no_limit'])
                                     ->end()
                                     ->integerNode('limit')
                                         ->info('The maximum allowed hits in a fixed interval or burst')
                                         ->isRequired()
                                     ->end()
                                     ->scalarNode('interval')
-                                        ->info('Configures the fixed interval if "strategy" is set to "fixed_window" or "sliding_window". The value must be a number followed by "second", "minute", "hour", "day", "week" or "month" (or their plural equivalent).')
+                                        ->info('Configures the fixed interval if "strategy" is set to "fixed_window", "sliding_window" or "no_limit". The value must be a number followed by "second", "minute", "hour", "day", "week" or "month" (or their plural equivalent).')
                                     ->end()
                                     ->arrayNode('rate')
                                         ->info('Configures the fill rate if "strategy" is set to "token_bucket"')
diff --git a/src/Symfony/Component/RateLimiter/RateLimiter.php b/src/Symfony/Component/RateLimiter/RateLimiter.php
@@ -54,8 +54,11 @@ public function create(?string $key = null): LimiterInterface
             case 'sliding_window':
                 return new SlidingWindowLimiter($id, $this->config['limit'], $this->config['interval'], $this->storage, $lock);
 
+            case 'no_limit':
+                return new NoLimiter();
+
             default:
-                throw new \LogicException(sprintf('Limiter strategy "%s" does not exists, it must be either "token_bucket", "sliding_window" or "fixed_window".', $this->config['strategy']));
+                throw new \LogicException(sprintf('Limiter strategy "%s" does not exists, it must be either "token_bucket", "sliding_window", "fixed_window" or "no_limit".', $this->config['strategy']));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,11 @@ public function create(?string $key = null): LimiterInterface`
`54`	`54`	`case 'sliding_window':`
`55`	`55`	`return new SlidingWindowLimiter($id, $this->config['limit'], $this->config['interval'], $this->storage, $lock);`
`56`	`56`
	`57`	`+ case 'no_limit':`
	`58`	`+ return new NoLimiter();`
	`59`	`+`
`57`	`60`	`default:`
`58`		`- throw new \LogicException(sprintf('Limiter strategy "%s" does not exists, it must be either "token_bucket", "sliding_window" or "fixed_window".', $this->config['strategy']));`
	`61`	`+ throw new \LogicException(sprintf('Limiter strategy "%s" does not exists, it must be either "token_bucket", "sliding_window", "fixed_window" or "no_limit".', $this->config['strategy']));`
`59`	`62`	`}`
`60`	`63`	`}`
`61`	`64`