Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 49931f4

Browse files
nicolas-grekasnicolas-grekas
committed
[Bridge\PhpUnit] Add "disabled" mode to SYMFONY_DEPRECATIONS_HELPER
1 parent 83ebf97 commit 49931f4

7 files changed

Lines changed: 164 additions & 8 deletions

File tree

‎src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php‎

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
class DeprecationErrorHandler
2020
{
2121
const MODE_WEAK = 'weak';
22+
const MODE_DISABLED = 'disabled';
2223

2324
private static $isRegistered = false;
2425

@@ -39,9 +40,23 @@ public static function register($mode = 0)
3940
if (self::$isRegistered) {
4041
return;
4142
}
42-
if (self::MODE_WEAK !== $mode && (!isset($mode[0]) || '/' !== $mode[0])) {
43-
$mode = preg_match('/^[1-9][0-9]*$/', $mode) ? (int) $mode : 0;
44-
}
43+
44+
$mode = function () use ($mode) {
45+
static $memoizedMode = false;
46+
47+
if (false !== $memoizedMode) {
48+
return $memoizedMode;
49+
}
50+
if (false === $mode) {
51+
$mode = getenv('SYMFONY_DEPRECATIONS_HELPER');
52+
}
53+
if (DeprecationErrorHandler::MODE_WEAK !== $mode && (!isset($mode[0]) || '/' !== $mode[0])) {
54+
$mode = preg_match('/^[1-9][0-9]*$/', $mode) ? (int) $mode : 0;
55+
}
56+
57+
return $memoizedMode = $mode;
58+
};
59+
4560
$deprecations = array(
4661
'unsilencedCount' => 0,
4762
'remainingCount' => 0,
@@ -53,7 +68,7 @@ public static function register($mode = 0)
5368
'other' => array(),
5469
);
5570
$deprecationHandler = function ($type, $msg, $file, $line, $context) use (&$deprecations, $mode) {
56-
if (E_USER_DEPRECATED !== $type) {
71+
if (E_USER_DEPRECATED !== $type || DeprecationErrorHandler::MODE_DISABLED === $mode = $mode()) {
5772
return \PHPUnit_Util_ErrorHandler::handleError($type, $msg, $file, $line, $context);
5873
}
5974

@@ -95,13 +110,13 @@ public static function register($mode = 0)
95110

96111
exit(1);
97112
}
98-
if ('legacy' !== $group && self::MODE_WEAK !== $mode) {
113+
if ('legacy' !== $group && DeprecationErrorHandler::MODE_WEAK !== $mode) {
99114
$ref = &$deprecations[$group][$msg]['count'];
100115
++$ref;
101116
$ref = &$deprecations[$group][$msg][$class.'::'.$method];
102117
++$ref;
103118
}
104-
} else {
119+
} elseif (DeprecationErrorHandler::MODE_WEAK !== $mode) {
105120
$group = 'other';
106121
$ref = &$deprecations[$group][$msg]['count'];
107122
++$ref;
@@ -116,7 +131,7 @@ public static function register($mode = 0)
116131
restore_error_handler();
117132
self::register($mode);
118133
}
119-
} elseif (!isset($mode[0]) || '/' !== $mode[0]) {
134+
} else {
120135
self::$isRegistered = true;
121136
if (self::hasColorSupport()) {
122137
$colorize = function ($str, $red) {
@@ -128,9 +143,16 @@ public static function register($mode = 0)
128143
$colorize = function ($str) {return $str;};
129144
}
130145
register_shutdown_function(function () use ($mode, &$deprecations, $deprecationHandler, $colorize) {
146+
$mode = $mode();
147+
if (isset($mode[0]) && '/' === $mode[0]) {
148+
return;
149+
}
131150
$currErrorHandler = set_error_handler('var_dump');
132151
restore_error_handler();
133152

153+
if (DeprecationErrorHandler::MODE_WEAK === $mode) {
154+
$colorize = function ($str) {return $str;};
155+
}
134156
if ($currErrorHandler !== $deprecationHandler) {
135157
echo "\n", $colorize('THE ERROR HANDLER HAS CHANGED!', true), "\n";
136158
}

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/default.phpt‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
--TEST--
2+
Test DeprecationErrorHandler in default mode
3+
--FILE--
4+
<?php
5+
6+
putenv('SYMFONY_DEPRECATIONS_HELPER');
7+
define('PHPUNIT_COMPOSER_INSTALL', __DIR__.'/../../vendor/autoload.php');
8+
require PHPUNIT_COMPOSER_INSTALL;
9+
10+
@trigger_error('root deprecation', E_USER_DEPRECATED);
11+
12+
class PHPUnit_Util_Test
13+
{
14+
public static function getGroups()
15+
{
16+
return array();
17+
}
18+
}
19+
20+
class FooTestCase
21+
{
22+
public function testLegacyFoo()
23+
{
24+
@trigger_error('silenced foo deprecation', E_USER_DEPRECATED);
25+
trigger_error('unsilenced foo deprecation', E_USER_DEPRECATED);
26+
}
27+
28+
public function testNonLegacyBar()
29+
{
30+
@trigger_error('silenced bar deprecation', E_USER_DEPRECATED);
31+
trigger_error('unsilenced bar deprecation', E_USER_DEPRECATED);
32+
}
33+
}
34+
35+
$foo = new FooTestCase();
36+
$foo->testLegacyFoo();
37+
$foo->testNonLegacyBar();
38+
39+
--EXPECTF--
40+
Unsilenced deprecation notices (2)
41+
42+
unsilenced foo deprecation: 1x
43+
1x in FooTestCase::testLegacyFoo
44+
45+
unsilenced bar deprecation: 1x
46+
1x in FooTestCase::testNonLegacyBar
47+
48+
Remaining deprecation notices (1)
49+
50+
silenced bar deprecation: 1x
51+
1x in FooTestCase::testNonLegacyBar
52+
53+
Legacy deprecation notices (1)
54+
55+
Other deprecation notices (1)
56+
57+
root deprecation: 1x
58+

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/disabled.phpt‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
--TEST--
2+
Test DeprecationErrorHandler in weak mode
3+
--FILE--
4+
<?php
5+
6+
putenv('SYMFONY_DEPRECATIONS_HELPER=disabled');
7+
define('PHPUNIT_COMPOSER_INSTALL', __DIR__.'/../../vendor/autoload.php');
8+
require PHPUNIT_COMPOSER_INSTALL;
9+
10+
echo (int) set_error_handler('var_dump');
11+
echo (int) class_exists('Symfony\Bridge\PhpUnit\DeprecationErrorHandler', false);
12+
13+
--EXPECTF--
14+
00

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/regexp.phpt‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
--TEST--
2+
Test DeprecationErrorHandler in weak mode
3+
--FILE--
4+
<?php
5+
6+
putenv('SYMFONY_DEPRECATIONS_HELPER=/foo/');
7+
define('PHPUNIT_COMPOSER_INSTALL', __DIR__.'/../../vendor/autoload.php');
8+
require PHPUNIT_COMPOSER_INSTALL;
9+
10+
@trigger_error('root deprecation', E_USER_DEPRECATED);
11+
12+
class FooTestCase
13+
{
14+
public function testLegacyFoo()
15+
{
16+
@trigger_error('silenced foo deprecation', E_USER_DEPRECATED);
17+
trigger_error('unsilenced foo deprecation', E_USER_DEPRECATED);
18+
}
19+
}
20+
21+
$foo = new FooTestCase();
22+
$foo->testLegacyFoo();
23+
24+
--EXPECTF--
25+
Legacy deprecation triggered by FooTestCase::testLegacyFoo:
26+
silenced foo deprecation
27+
Stack trace:
28+
#0 -(13): trigger_error()
29+
#1 -(19): FooTestCase->testLegacyFoo()
30+
#2 {main}
31+

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/weak.phpt‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
--TEST--
2+
Test DeprecationErrorHandler in weak mode
3+
--FILE--
4+
<?php
5+
6+
putenv('SYMFONY_DEPRECATIONS_HELPER=weak');
7+
define('PHPUNIT_COMPOSER_INSTALL', __DIR__.'/../../vendor/autoload.php');
8+
require PHPUNIT_COMPOSER_INSTALL;
9+
10+
@trigger_error('root deprecation', E_USER_DEPRECATED);
11+
12+
class FooTestCase
13+
{
14+
public function testLegacyFoo()
15+
{
16+
@trigger_error('silenced foo deprecation', E_USER_DEPRECATED);
17+
trigger_error('unsilenced foo deprecation', E_USER_DEPRECATED);
18+
}
19+
}
20+
21+
$foo = new FooTestCase();
22+
$foo->testLegacyFoo();
23+
24+
--EXPECTF--
25+
Unsilenced deprecation notices (1)
26+
27+
Legacy deprecation notices (1)
28+

‎src/Symfony/Bridge/PhpUnit/bootstrap.php‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,6 @@
2424
AnnotationRegistry::registerLoader('class_exists');
2525
}
2626

27-
DeprecationErrorHandler::register(getenv('SYMFONY_DEPRECATIONS_HELPER'));
27+
if ('disabled' !== getenv('SYMFONY_DEPRECATIONS_HELPER')) {
28+
DeprecationErrorHandler::register(getenv('SYMFONY_DEPRECATIONS_HELPER'));
29+
}

‎src/Symfony/Bridge/PhpUnit/phpunit.xml.dist‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<testsuites>
1414
<testsuite name="Symfony PHPUnit Bridge Test Suite">
1515
<directory>./Tests/</directory>
16+
<directory suffix=".phpt">./Tests/DeprecationErrorHandler/</directory>
1617
</testsuite>
1718
</testsuites>
1819

0 commit comments

Comments
 (0)