feature #53680 [DependencyInjection][Yaml] dump enums with the !php/enum tag (xabbuh)

nicolas-grekas · nicolas-grekas · commit 4a49af85ea8f · 2024-01-30T15:04:30.000+01:00
This PR was merged into the 7.1 branch. Discussion ---------- [DependencyInjection][Yaml] dump enums with the !php/enum tag | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #53636 | License | MIT Commits ------- 661cc42 dump enums with the !php/enum tag
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -116,7 +116,7 @@ public static function dump(mixed $value, int $flags = 0): string
                     default => 'Y-m-d\TH:i:s.uP',
                 });
             case $value instanceof \UnitEnum:
-                return sprintf('!php/const %s::%s', $value::class, $value->name);
+                return sprintf('!php/enum %s::%s', $value::class, $value->name);
             case \is_object($value):
                 if ($value instanceof TaggedValue) {
                     return '!'.$value->getTag().' '.self::dump($value->getValue(), $flags);
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -715,7 +715,7 @@ public static function getNumericKeyData()
 
     public function testDumpUnitEnum()
     {
-        $this->assertSame("!php/const Symfony\Component\Yaml\Tests\Fixtures\FooUnitEnum::BAR", Inline::dump(FooUnitEnum::BAR));
+        $this->assertSame("!php/enum Symfony\Component\Yaml\Tests\Fixtures\FooUnitEnum::BAR", Inline::dump(FooUnitEnum::BAR));
     }
 
     public function testParseUnitEnum()

Original file line number	Diff line number	Diff line change
`@@ -715,7 +715,7 @@ public static function getNumericKeyData()`
`715`	`715`
`716`	`716`	`public function testDumpUnitEnum()`
`717`	`717`	`{`
`718`		`- $this->assertSame("!php/const Symfony\Component\Yaml\Tests\Fixtures\FooUnitEnum::BAR", Inline::dump(FooUnitEnum::BAR));`
	`718`	`+ $this->assertSame("!php/enum Symfony\Component\Yaml\Tests\Fixtures\FooUnitEnum::BAR", Inline::dump(FooUnitEnum::BAR));`
`719`	`719`	`}`
`720`	`720`
`721`	`721`	`public function testParseUnitEnum()`