[Finder] fix reverse sorting custom-ordering functions

nicolas-grekas · nicolas-grekas · commit 4d70a0b7d458 · 2018-10-10T06:30:17.000-07:00
diff --git a/src/Symfony/Component/Finder/Iterator/SortableIterator.php b/src/Symfony/Component/Finder/Iterator/SortableIterator.php
@@ -73,7 +73,7 @@ public function __construct(\Traversable $iterator, $sort, bool $reverseOrder =
         } elseif (self::SORT_BY_NONE === $sort) {
             $this->sort = $order;
         } elseif (\is_callable($sort)) {
-            $this->sort = $sort;
+            $this->sort = $reverseOrder ? function ($a, $b) use ($sort) { return -\call_user_func($sort, $a, $b); } : $sort;
         } else {
             throw new \InvalidArgumentException('The SortableIterator takes a PHP callable or a valid built-in sort algorithm as an argument.');
         }

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function __construct(\Traversable $iterator, $sort, bool $reverseOrder =`
`73`	`73`	`} elseif (self::SORT_BY_NONE === $sort) {`
`74`	`74`	`$this->sort = $order;`
`75`	`75`	`} elseif (\is_callable($sort)) {`
`76`		`- $this->sort = $sort;`
	`76`	`+ $this->sort = $reverseOrder ? function ($a, $b) use ($sort) { return -\call_user_func($sort, $a, $b); } : $sort;`
`77`	`77`	`} else {`
`78`	`78`	`throw new \InvalidArgumentException('The SortableIterator takes a PHP callable or a valid built-in sort algorithm as an argument.');`
`79`	`79`	`}`