bug #62240 [DomCrawler] Handle malformed tags in HTML5 parser (longwave)

nicolas-grekas · nicolas-grekas · commit 4e517b78e979 · 2025-10-31T10:30:07.000+01:00
This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [DomCrawler] Handle malformed tags in HTML5 parser | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62236 | License | MIT Fixes DomCrawler to not crash if it encounters a malformed HTML tag; however the behaviour is still different from the previous version if I naively catch and ignore the exception, as demonstrated by the test case; it should pass on PHP 8.3 and fail on 8.4. Commits ------- 471acb7 [DomCrawler] Handle malformed tags in HTML5 parser
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -1272,7 +1272,11 @@ private function copyFromHtml5ToDom(\Dom\Node $source, \DOMDocument $target): vo
                     continue;
                 }
 
-                $element = $target->createElement($source->tagName);
+                try {
+                    $element = $target->createElement($source->tagName);
+                } catch (\DOMException) {
+                    continue;
+                }
 
                 foreach ($source->attributes as $attr) {
                     try {
diff --git a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
@@ -1380,6 +1380,13 @@ public static function html5Provider(): iterable
         yield 'All together' => [$BOM.'  <!--c-->'.$html];
     }
 
+    public function testHtml5MalformedContent()
+    {
+        $crawler = $this->createCrawler();
+        $crawler->addHtmlContent('<script&>');
+        self::assertEquals('<head></head><body></body>', $crawler->html());
+    }
+
     public function testAlpineJs()
     {
         $crawler = $this->createCrawler();
diff --git a/src/Symfony/Component/DomCrawler/Tests/LegacyHtml5ParserCrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/LegacyHtml5ParserCrawlerTest.php
@@ -72,6 +72,13 @@ public static function invalidHtml5Provider(): iterable
         yield 'Text between comments' => ['<!--c--> test <!--cc-->'.$html];
     }
 
+    public function testHtml5MalformedContent()
+    {
+        $crawler = $this->createCrawler();
+        $crawler->addHtmlContent('<script&>');
+        self::assertEquals('<head><script></script></head>', $crawler->html());
+    }
+
     protected function createCrawler($node = null, ?string $uri = null, ?string $baseHref = null)
     {
         return new Crawler($node, $uri, $baseHref, true);
diff --git a/src/Symfony/Component/DomCrawler/Tests/LegacyParserCrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/LegacyParserCrawlerTest.php
@@ -95,4 +95,11 @@ public function testAddHtml5()
     public function testHtml5ParserParseContentStartingWithValidHeading(string $content)
     {
     }
+
+    public function testHtml5MalformedContent()
+    {
+        $crawler = $this->createCrawler();
+        $crawler->addHtmlContent('<script&>');
+        self::assertEquals('<head><script></script></head>', $crawler->html());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -1380,6 +1380,13 @@ public static function html5Provider(): iterable`
`1380`	`1380`	`yield 'All together' => [$BOM.' <!--c-->'.$html];`
`1381`	`1381`	`}`
`1382`	`1382`
	`1383`	`+ public function testHtml5MalformedContent()`
	`1384`	`+ {`
	`1385`	`+ $crawler = $this->createCrawler();`
	`1386`	`+ $crawler->addHtmlContent('<script&>');`
	`1387`	`+ self::assertEquals('<head></head><body></body>', $crawler->html());`
	`1388`	`+ }`
	`1389`	`+`
`1383`	`1390`	`public function testAlpineJs()`
`1384`	`1391`	`{`
`1385`	`1392`	`$crawler = $this->createCrawler();`
Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,13 @@ public static function invalidHtml5Provider(): iterable`
`72`	`72`	`yield 'Text between comments' => ['<!--c--> test <!--cc-->'.$html];`
`73`	`73`	`}`
`74`	`74`
	`75`	`+ public function testHtml5MalformedContent()`
	`76`	`+ {`
	`77`	`+ $crawler = $this->createCrawler();`
	`78`	`+ $crawler->addHtmlContent('<script&>');`
	`79`	`+ self::assertEquals('<head><script></script></head>', $crawler->html());`
	`80`	`+ }`
	`81`	`+`
`75`	`82`	`protected function createCrawler($node = null, ?string $uri = null, ?string $baseHref = null)`
`76`	`83`	`{`
`77`	`84`	`return new Crawler($node, $uri, $baseHref, true);`
Original file line number	Diff line number	Diff line change
`@@ -95,4 +95,11 @@ public function testAddHtml5()`
`95`	`95`	`public function testHtml5ParserParseContentStartingWithValidHeading(string $content)`
`96`	`96`	`{`
`97`	`97`	`}`
	`98`	`+`
	`99`	`+ public function testHtml5MalformedContent()`
	`100`	`+ {`
	`101`	`+ $crawler = $this->createCrawler();`
	`102`	`+ $crawler->addHtmlContent('<script&>');`
	`103`	`+ self::assertEquals('<head><script></script></head>', $crawler->html());`
	`104`	`+ }`
`98`	`105`	`}`