do not overwrite the host to request

xabbuh · xabbuh · commit 5017efadd008 · 2024-08-20T16:48:02.000+02:00
diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php
@@ -185,10 +185,10 @@ public function request(string $method, string $url, array $options = []): Respo
                 $multi->reset();
             }
 
-            foreach ($options['resolve'] as $host => $ip) {
-                $resolve[] = null === $ip ? "-$host:$port" : "$host:$port:$ip";
-                $multi->dnsCache->hostnames[$host] = $ip;
-                $multi->dnsCache->removals["-$host:$port"] = "-$host:$port";
+            foreach ($options['resolve'] as $resolveHost => $ip) {
+                $resolve[] = null === $ip ? "-$resolveHost:$port" : "$resolveHost:$port:$ip";
+                $multi->dnsCache->hostnames[$resolveHost] = $ip;
+                $multi->dnsCache->removals["-$resolveHost:$port"] = "-$resolveHost:$port";
             }
 
             $curlopts[\CURLOPT_RESOLVE] = $resolve;
diff --git a/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php
@@ -128,4 +128,20 @@ public function testOverridingInternalAttributesUsingCurlOptions()
             ],
         ]);
     }
+
+    public function testKeepAuthorizationHeaderOnRedirectToSameHostWithConfiguredHostToIpAddressMapping()
+    {
+        $httpClient = $this->getHttpClient(__FUNCTION__);
+        $response = $httpClient->request('POST', 'http://127.0.0.1:8057/301', [
+            'headers' => [
+                'Authorization' => 'Basic Zm9vOmJhcg==',
+            ],
+            'resolve' => [
+                'symfony.com' => '10.10.10.10',
+            ],
+        ]);
+
+        $this->assertSame(200, $response->getStatusCode());
+        $this->assertSame('/302', $response->toArray()['REQUEST_URI'] ?? null);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -185,10 +185,10 @@ public function request(string $method, string $url, array $options = []): Respo`
`185`	`185`	`$multi->reset();`
`186`	`186`	`}`
`187`	`187`
`188`		`- foreach ($options['resolve'] as $host => $ip) {`
`189`		`- $resolve[] = null === $ip ? "-$host:$port" : "$host:$port:$ip";`
`190`		`- $multi->dnsCache->hostnames[$host] = $ip;`
`191`		`- $multi->dnsCache->removals["-$host:$port"] = "-$host:$port";`
	`188`	`+ foreach ($options['resolve'] as $resolveHost => $ip) {`
	`189`	`+ $resolve[] = null === $ip ? "-$resolveHost:$port" : "$resolveHost:$port:$ip";`
	`190`	`+ $multi->dnsCache->hostnames[$resolveHost] = $ip;`
	`191`	`+ $multi->dnsCache->removals["-$resolveHost:$port"] = "-$resolveHost:$port";`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`$curlopts[\CURLOPT_RESOLVE] = $resolve;`