[Finder] Fixed leading/trailing / in filename

lyrixx · lyrixx · commit 514cd9d6edf2 · 2018-02-28T09:29:56.000+01:00
Without this patch, we go this:

```
--- Expected
+++ Actual
@@ @@
 Array (
-    0 =&gt; '/tmp/symfony_finder/foo bar'
-    1 =&gt; '/tmp/symfony_finder/foo/bar.tmp'
-    2 =&gt; '/tmp/symfony_finder/test.php'
-    3 =&gt; '/tmp/symfony_finder/test.py'
+    0 =&gt; '///tmp/symfony_finder///foo bar'
+    1 =&gt; '///tmp/symfony_finder///foo/bar.tmp'
+    2 =&gt; '///tmp/symfony_finder///test.php'
+    3 =&gt; '///tmp/symfony_finder///test.py'
 )
```
diff --git a/src/Symfony/Component/Finder/SplFileInfo.php b/src/Symfony/Component/Finder/SplFileInfo.php
@@ -28,7 +28,7 @@ class SplFileInfo extends \SplFileInfo
      */
     public function __construct($file, $relativePath, $relativePathname)
     {
-        parent::__construct($file);
+        parent::__construct(realpath($file));
         $this->relativePath = $relativePath;
         $this->relativePathname = $relativePathname;
     }
diff --git a/src/Symfony/Component/Finder/Tests/FinderTest.php b/src/Symfony/Component/Finder/Tests/FinderTest.php
@@ -48,6 +48,16 @@ public function testFiles()
         $this->assertIterator($this->toAbsolute(array('foo/bar.tmp', 'test.php', 'test.py', 'foo bar')), $finder->in(self::$tmpDir)->getIterator());
     }
 
+    public function testRemoveTrailingSlash()
+    {
+        $finder = $this->buildFinder();
+
+        $expected = $this->toAbsolute(array('foo/bar.tmp', 'test.php', 'test.py', 'foo bar'));
+        $in = '//'.realpath(self::$tmpDir).'//';
+
+        $this->assertIterator($expected, $finder->in($in)->files()->getIterator());
+    }
+
     public function testDepth()
     {
         $finder = $this->buildFinder();

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class SplFileInfo extends \SplFileInfo`
`28`	`28`	`*/`
`29`	`29`	`public function __construct($file, $relativePath, $relativePathname)`
`30`	`30`	`{`
`31`		`- parent::__construct($file);`
	`31`	`+ parent::__construct(realpath($file));`
`32`	`32`	`$this->relativePath = $relativePath;`
`33`	`33`	`$this->relativePathname = $relativePathname;`
`34`	`34`	`}`