Add an entry on json export format

Pascal Montoya · Pascal Montoya · commit 54f66a7974ef · 2018-05-14T12:06:57.000+02:00
diff --git a/src/Symfony/Bridge/Twig/CHANGELOG.md b/src/Symfony/Bridge/Twig/CHANGELOG.md
@@ -5,7 +5,7 @@ CHANGELOG
 -----
 
  * add a `workflow_metadata` function
- * add bundle name suggestion on wrongly overrided templates paths
+ * add bundle name suggestion on wrongly overridden templates paths
 
 3.4.0
 -----
diff --git a/src/Symfony/Bridge/Twig/Command/DebugCommand.php b/src/Symfony/Bridge/Twig/Command/DebugCommand.php
@@ -88,8 +88,20 @@ protected function execute(InputInterface $input, OutputInterface $output)
             }
             $data['tests'] = array_keys($data['tests']);
             $data['loader_paths'] = $this->getLoaderPaths();
+            if ($wrongBundles = $this->findWrongBundleOverrides()) {
+                $messages = $this->buildWarningMessages($wrongBundles);
+                $data['warnings'] = array_reduce(
+                    $messages,
+                    function ($carry, $message) {
+                        $carry[] = $message;
+
+                        return $carry;
+                    },
+                    array()
+                );
+            }
+
             $io->writeln(json_encode($data));
-            $this->displayAlternatives($this->findWrongBundleOverrides(), $io);
 
             return 0;
         }
@@ -130,7 +142,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
         array_pop($rows);
         $io->section('Loader Paths');
         $io->table(array('Namespace', 'Paths'), $rows);
-        $this->displayAlternatives($this->findWrongBundleOverrides(), $io);
+        $messages = $this->buildWarningMessages($this->findWrongBundleOverrides());
+        array_walk(
+            $messages,
+            function ($message) use ($io) {
+                $io->warning(trim($message));
+            }
+         );
 
         return 0;
     }
@@ -293,13 +311,12 @@ function ($carry, $absolutePath) use ($relativePath) {
         }
 
         if (\count($bundleNames)) {
-            $loadedBundles = $this->bundlesMetadata;
-            $notFoundBundles = array_diff_key($bundleNames, $loadedBundles);
+            $notFoundBundles = array_diff_key($bundleNames, $this->bundlesMetadata);
             if (\count($notFoundBundles)) {
                 $alternatives = array();
                 foreach ($notFoundBundles as $notFoundBundle => $path) {
                     $alternatives[$path] = array();
-                    foreach ($loadedBundles as $name => $bundle) {
+                    foreach ($this->bundlesMetadata as $name => $bundle) {
                         $lev = levenshtein($notFoundBundle, $name);
                         if ($lev <= \strlen($notFoundBundle) / 3 || false !== strpos($name, $notFoundBundle)) {
                             $alternatives[$path][] = $name;
@@ -312,8 +329,9 @@ function ($carry, $absolutePath) use ($relativePath) {
         return $alternatives;
     }
 
-    private function displayAlternatives(array $wrongBundles, SymfonyStyle $io): void
+    private function buildWarningMessages(array $wrongBundles): array
     {
+        $messages = array();
         foreach ($wrongBundles as $path => $alternatives) {
             $message = sprintf('Path "%s" not matching any bundle found', $path);
             if ($alternatives) {
@@ -326,7 +344,9 @@ private function displayAlternatives(array $wrongBundles, SymfonyStyle $io): voi
                     }
                 }
             }
-            $io->warning(trim($message));
+            $messages[] = $message;
         }
+
+        return $messages;
     }
 }
