Test to ensure that getParameterOption / hasParameterOption throws no warnings.

greg-1-anderson · greg-1-anderson · commit 5636e484bd67 · 2018-02-14T11:24:01.000-08:00
diff --git a/src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php b/src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php
@@ -19,6 +19,12 @@
 
 class ArgvInputTest extends TestCase
 {
+    protected $last_error = '';
+
+    public function customErrorHandler($errno, $errstr, $errfile, $errline) {
+        $this->last_error = $errstr . " on line " . $errline . " in file " . $errfile;
+    }
+
     public function testConstructor()
     {
         $_SERVER['argv'] = array('cli.php', 'foo');
@@ -337,6 +343,21 @@ public function testHasParameterOptionEdgeCasesAndLimitations()
         $this->assertFalse($input->hasParameterOption('-fh'), '->hasParameterOption() returns true if the given short option is in the raw input');
     }
 
+    public function testNoWarningOnInvalidParameterOption()
+    {
+        $input = new ArgvInput(array('cli.php', '-edev'));
+
+        // Control.
+        $this->assertTrue($input->hasParameterOption(['-e', '']));
+        // No warning is thrown if https://github.com/symfony/symfony/pull/26156 is fixed
+        $this->assertFalse($input->hasParameterOption(['-m', '']));
+
+        // Control.
+        $this->assertEquals('dev', $input->getParameterOption(['-e', '']));
+        // No warning is thrown if https://github.com/symfony/symfony/pull/26156 is fixed
+        $this->assertEquals('', $input->getParameterOption(['-m', '']));
+    }
+
     public function testToString()
     {
         $input = new ArgvInput(array('cli.php', '-f', 'foo'));
