Another angle

smnandre · smnandre · commit 568eb1ba75fd · 2024-08-12T13:41:38.000+02:00
diff --git a/src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php b/src/Symfony/Component/AssetMapper/ImportMap/RemotePackageStorage.php
@@ -63,6 +63,10 @@ public function save(ImportMapEntry $entry, string $contents): void
         } catch (IOException $e) {
             throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath), 0, $e);
         }
+
+        if (!is_file($vendorPath) || !is_writable($vendorPath)) {
+            throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath));
+        }
     }
 
     public function saveExtraFile(ImportMapEntry $entry, string $extraFilename, string $contents): void
@@ -78,6 +82,10 @@ public function saveExtraFile(ImportMapEntry $entry, string $extraFilename, stri
         } catch (IOException $e) {
             throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath), 0, $e);
         }
+
+        if (!is_file($vendorPath) || !is_writable($vendorPath)) {
+            throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath));
+        }
     }
 
     /**
diff --git a/src/Symfony/Component/AssetMapper/Tests/ImportMap/RemotePackageStorageTest.php b/src/Symfony/Component/AssetMapper/Tests/ImportMap/RemotePackageStorageTest.php
@@ -46,19 +46,15 @@ public function testSaveThrowsWhenFailing()
         $vendorDir = self::$writableRoot.'/assets/acme/vendor';
         $this->filesystem->mkdir($vendorDir.'/module_specifier');
         $this->filesystem->touch($vendorDir.'/module_specifier/module_specifier.index.js');
-        $this->filesystem->chmod($vendorDir.'/module_specifier', 0555);
+        $this->filesystem->chmod($vendorDir.'/module_specifier/module_specifier.index.js', 0555);
 
         $storage = new RemotePackageStorage($vendorDir);
         $entry = ImportMapEntry::createRemote('foo', ImportMapType::JS, '/does/not/matter', '1.0.0', 'module_specifier', false);
 
         $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('Failed to write file "'.$vendorDir.'/module_specifier/module_specifier.index.js');
 
-        try {
-            $storage->save($entry, 'any content');
-        } finally {
-            $this->filesystem->chmod($vendorDir.'/module_specifier/', 0777);
-        }
+        $storage->save($entry, 'any content');
     }
 
     public function testIsDownloaded()

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,10 @@ public function save(ImportMapEntry $entry, string $contents): void`
`63`	`63`	`} catch (IOException $e) {`
`64`	`64`	`throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath), 0, $e);`
`65`	`65`	`}`
	`66`	`+`
	`67`	`+ if (!is_file($vendorPath) \|\| !is_writable($vendorPath)) {`
	`68`	`+ throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath));`
	`69`	`+ }`
`66`	`70`	`}`
`67`	`71`
`68`	`72`	`public function saveExtraFile(ImportMapEntry $entry, string $extraFilename, string $contents): void`
`@@ -78,6 +82,10 @@ public function saveExtraFile(ImportMapEntry $entry, string $extraFilename, stri`
`78`	`82`	`} catch (IOException $e) {`
`79`	`83`	`throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath), 0, $e);`
`80`	`84`	`}`
	`85`	`+`
	`86`	`+ if (!is_file($vendorPath) \|\| !is_writable($vendorPath)) {`
	`87`	`+ throw new RuntimeException(\sprintf('Failed to write file "%s".', $vendorPath));`
	`88`	`+ }`
`81`	`89`	`}`
`82`	`90`
`83`	`91`	`/**`