bug #37853 [Validator] ensure that the validator is a mock object for backwards-compatibility (xabbuh)

fabpot · fabpot · commit 58166dfd7549 · 2020-08-17T13:51:16.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] ensure that the validator is a mock object for backwards-compatibility | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | I accidentally broke the class in #37808. The validator was a mock object before (see the failing tests on the `5.1` branch). Commits ------- 1c9b671 ensure that the validator is a mock object for backwards-compatibility
diff --git a/src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php b/src/Symfony/Component/Validator/Test/ConstraintValidatorTestCase.php
@@ -115,7 +115,7 @@ protected function createContext()
         $validator->expects($this->any())
             ->method('inContext')
             ->with($context)
-            ->willReturn(new AssertingContextualValidator());
+            ->willReturn($this->createMock(AssertingContextualValidator::class));
 
         return $context;
     }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ protected function createContext()`
`115`	`115`	`$validator->expects($this->any())`
`116`	`116`	`->method('inContext')`
`117`	`117`	`->with($context)`
`118`		`- ->willReturn(new AssertingContextualValidator());`
	`118`	`+ ->willReturn($this->createMock(AssertingContextualValidator::class));`
`119`	`119`
`120`	`120`	`return $context;`
`121`	`121`	`}`