Improve tests

dunglas · dunglas · commit 5856f27a298b · 2019-01-27T19:29:39.000+01:00
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/NotBlankValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/NotBlankValidatorTest.php
@@ -99,32 +99,29 @@ public function testEmptyArrayIsInvalid()
             ->assertRaised();
     }
 
-    /**
-     * @dataProvider provideAllowNull
-     */
-    public function testAllowNull(bool $allowNull)
+    public function testAllowNullTrue()
     {
-        $constraint = new NotBlank(array(
+        $constraint = new NotBlank([
             'message' => 'myMessage',
-            'allowNull' => $allowNull,
-        ));
+            'allowNull' => true,
+        ]);
 
         $this->validator->validate(null, $constraint);
+        $this->assertNoViolation();
+    }
 
-        if ($allowNull) {
-            $this->assertNoViolation();
+    public function testAllowNullFalse()
+    {
+        $constraint = new NotBlank([
+            'message' => 'myMessage',
+            'allowNull' => false,
+        ]);
 
-            return;
-        }
+        $this->validator->validate(null, $constraint);
 
         $this->buildViolation('myMessage')
             ->setParameter('{{ value }}', 'null')
             ->setCode(NotBlank::IS_BLANK_ERROR)
             ->assertRaised();
     }
-
-    public function provideAllowNull(): array
-    {
-        return array(array(true), array(false));
-    }
 }
