[Filesystem] Try to delete broken symlinks

IchHabRecht · IchHabRecht · commit 58dd0b9cc948 · 2016-01-31T14:43:18.000+01:00
If you delete the target of a symlink (at least on Windows systems) you
don't get the kind of the target anymore (obviously). Therefore it might
happen that a broken symlink to a directory should be removed with
unlink() which fails. This patch adds another check for a broken symlink
and tries to remove with rmdir() before throwing an exception. It helps
to clean up test folders on Windows systems (so already proofed by the
existing tests).
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -172,7 +172,14 @@ public function remove($files)
                     }
                 } else {
                     if (true !== @unlink($file)) {
-                        throw new IOException(sprintf('Failed to remove file "%s".', $file), 0, null, $file);
+                        // handle broken symlinks on Windows systems
+                        if (is_link($file) && false === @readlink($file)) {
+                            if (true !== @rmdir($file)) {
+                                throw new IOException(sprintf('Failed to remove broken symlink "%s".', $file), 0, null, $file);
+                            }
+                        } else {
+                            throw new IOException(sprintf('Failed to remove file "%s".', $file), 0, null, $file);
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,14 @@ public function remove($files)`
`172`	`172`	`}`
`173`	`173`	`} else {`
`174`	`174`	`if (true !== @unlink($file)) {`
`175`		`- throw new IOException(sprintf('Failed to remove file "%s".', $file), 0, null, $file);`
	`175`	`+ // handle broken symlinks on Windows systems`
	`176`	`+ if (is_link($file) && false === @readlink($file)) {`
	`177`	`+ if (true !== @rmdir($file)) {`
	`178`	`+ throw new IOException(sprintf('Failed to remove broken symlink "%s".', $file), 0, null, $file);`
	`179`	`+ }`
	`180`	`+ } else {`
	`181`	`+ throw new IOException(sprintf('Failed to remove file "%s".', $file), 0, null, $file);`
	`182`	`+ }`
`176`	`183`	`}`
`177`	`184`	`}`
`178`	`185`	`}`