[Messenger] Allow passing a string instead of an array in TransportNamesStamp

alexandre-daubois · alexandre-daubois · commit 591f1f4883af · 2023-02-07T11:21:28.000+01:00
diff --git a/src/Symfony/Component/Messenger/CHANGELOG.md b/src/Symfony/Component/Messenger/CHANGELOG.md
@@ -9,6 +9,7 @@ CHANGELOG
    `Symfony\Component\Messenger\Transport\InMemoryTransportFactory` in favor of
    `Symfony\Component\Messenger\Transport\InMemory\InMemoryTransport` and
    `Symfony\Component\Messenger\Transport\InMemory\InMemoryTransportFactory`
+ * Allow passing a string instead of an array in `TransportNamesStamp`
 
 6.2
 ---
diff --git a/src/Symfony/Component/Messenger/Stamp/TransportNamesStamp.php b/src/Symfony/Component/Messenger/Stamp/TransportNamesStamp.php
@@ -16,15 +16,18 @@
  */
 final class TransportNamesStamp implements StampInterface
 {
+    private array $transportNames;
+
     /**
-     * @param string[] $transports Transport names to be used for the message
+     * @param string[]|string $transports Transport names to be used for the message
      */
-    public function __construct(private array $transports)
+    public function __construct(array|string $transports)
     {
+        $this->transportNames = (array) $transports;
     }
 
     public function getTransportNames(): array
     {
-        return $this->transports;
+        return $this->transportNames;
     }
 }
diff --git a/src/Symfony/Component/Messenger/Tests/Stamp/TransportNamesStampTest.php b/src/Symfony/Component/Messenger/Tests/Stamp/TransportNamesStampTest.php
@@ -27,4 +27,13 @@ public function testGetSenders()
             $this->assertSame($sender, $stampSenders[$key]);
         }
     }
+
+    public function testGetIndividualSender()
+    {
+        $stamp = new TransportNamesStamp('first_transport');
+        $stampSenders = $stamp->getTransportNames();
+
+        $this->assertCount(1, $stampSenders);
+        $this->assertSame('first_transport', $stampSenders[0]);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -16,15 +16,18 @@`
`16`	`16`	`*/`
`17`	`17`	`final class TransportNamesStamp implements StampInterface`
`18`	`18`	`{`
	`19`	`+ private array $transportNames;`
	`20`	`+`
`19`	`21`	`/**`
`20`		`- * @param string[] $transports Transport names to be used for the message`
	`22`	`+ * @param string[]\|string $transports Transport names to be used for the message`
`21`	`23`	`*/`
`22`		`- public function __construct(private array $transports)`
	`24`	`+ public function __construct(array\|string $transports)`
`23`	`25`	`{`
	`26`	`+ $this->transportNames = (array) $transports;`
`24`	`27`	`}`
`25`	`28`
`26`	`29`	`public function getTransportNames(): array`
`27`	`30`	`{`
`28`		`- return $this->transports;`
	`31`	`+ return $this->transportNames;`
`29`	`32`	`}`
`30`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,4 +27,13 @@ public function testGetSenders()`
`27`	`27`	`$this->assertSame($sender, $stampSenders[$key]);`
`28`	`28`	`}`
`29`	`29`	`}`
	`30`	`+`
	`31`	`+ public function testGetIndividualSender()`
	`32`	`+ {`
	`33`	`+ $stamp = new TransportNamesStamp('first_transport');`
	`34`	`+ $stampSenders = $stamp->getTransportNames();`
	`35`	`+`
	`36`	`+ $this->assertCount(1, $stampSenders);`
	`37`	`+ $this->assertSame('first_transport', $stampSenders[0]);`
	`38`	`+ }`
`30`	`39`	`}`