bug #50665 [FrameworkBundle] Ignore missing directories in about command (ro0NL)

fabpot · fabpot · commit 5c512f606997 · 2023-06-21T07:15:27.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Ignore missing directories in about command | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes IMHO | New feature? | no | Deprecations? | no | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...   This fixes our CI when `var/log` is missing. Before: ``` In AboutCommand.php line 105: [UnexpectedValueException] RecursiveDirectoryIterator::__construct(/app/var/log): Failed to open directory: No such file or directory ``` After: ``` Cache directory ./var/cache/prod (939 KiB) Build directory ./var/cache/prod (939 KiB) Log directory ./var/log (n/a) ``` Commits ------- 6dacc59 [FrameworkBundle] Ignore missing directories in about command
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php
@@ -109,6 +109,10 @@ private static function formatFileSize(string $path): string
         if (is_file($path)) {
             $size = filesize($path) ?: 0;
         } else {
+            if (!is_dir($path)) {
+                return 'n/a';
+            }
+
             $size = 0;
             foreach (new \RecursiveIteratorIterator(new \RecursiveDirectoryIterator($path, \RecursiveDirectoryIterator::SKIP_DOTS | \RecursiveDirectoryIterator::FOLLOW_SYMLINKS)) as $file) {
                 if ($file->isReadable()) {
