bug #40595 add missing queue_name to find(id) in doctrine messenger transport (monteiro)

chalasr · chalasr · commit 5dad87183333 · 2021-03-30T00:15:30.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- add missing queue_name to find(id) in doctrine messenger transport | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | License | MIT This bug was noticed by @weaverryan when reviewing the PR: #38468 related to multiple failure transports. Commits ------- bb26a92 add missing queue_name to find(id) in doctrine messenger transport
diff --git a/src/Symfony/Component/Messenger/Tests/Transport/Doctrine/ConnectionTest.php b/src/Symfony/Component/Messenger/Tests/Transport/Doctrine/ConnectionTest.php
@@ -284,6 +284,7 @@ public function testFind()
             ->willReturn($queryBuilder);
         $queryBuilder
             ->method('where')
+            ->with('m.id = ? and m.queue_name = ?')
             ->willReturn($queryBuilder);
         $queryBuilder
             ->method('getSQL')
diff --git a/src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php b/src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
@@ -291,9 +291,9 @@ public function findAll(int $limit = null): array
     public function find($id): ?array
     {
         $queryBuilder = $this->createQueryBuilder()
-            ->where('m.id = ?');
+            ->where('m.id = ? and m.queue_name = ?');
 
-        $stmt = $this->executeQuery($queryBuilder->getSQL(), [$id]);
+        $stmt = $this->executeQuery($queryBuilder->getSQL(), [$id, $this->configuration['queue_name']]);
         $data = $stmt instanceof Result || $stmt instanceof DriverResult ? $stmt->fetchAssociative() : $stmt->fetch();
 
         return false === $data ? null : $this->decodeEnvelopeHeaders($data);
