bug #34903 Fixing bad order of operations with null coalescing operator (weaverryan)

yceruto · yceruto · commit 5e75edf57898 · 2019-12-09T16:15:29.000-05:00
This PR was merged into the 4.4 branch. Discussion ---------- Fixing bad order of operations with null coalescing operator | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | None | License | MIT | Doc PR | not needed Hi! Reported by a user on SymfonyCasts :). Apparently without the parentheses, the order of operations is incorrect: https://3v4l.org/UZ7GU Thanks! Commits ------- 6291264 Fixing bad order of operations with null coalescing operator
diff --git a/src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php
@@ -41,7 +41,7 @@ public function __construct(bool $debug = false, array $defaultContext = [])
     public function normalize($exception, $format = null, array $context = [])
     {
         $context += $this->defaultContext;
-        $debug = $this->debug && $context['debug'] ?? true;
+        $debug = $this->debug && ($context['debug'] ?? true);
 
         $data = [
             'type' => $context['type'],

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function __construct(bool $debug = false, array $defaultContext = [])`
`41`	`41`	`public function normalize($exception, $format = null, array $context = [])`
`42`	`42`	`{`
`43`	`43`	`$context += $this->defaultContext;`
`44`		`- $debug = $this->debug && $context['debug'] ?? true;`
	`44`	`+ $debug = $this->debug && ($context['debug'] ?? true);`
`45`	`45`
`46`	`46`	`$data = [`
`47`	`47`	`'type' => $context['type'],`