feature #30357 [TwigBridge] rename parent_form() to form_parent() (xabbuh)

fabpot · fabpot · commit 5f8aa34396d9 · 2019-02-23T11:12:29.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [TwigBridge] rename parent_form() to form_parent() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#11049 We got some feedback on the blog post that form_parent() would be better for consistency with all the existing form_*() functions. I think that user has a point about that. Commits ------- 057d177 rename parent_form() to form_parent()
diff --git a/src/Symfony/Bridge/Twig/CHANGELOG.md b/src/Symfony/Bridge/Twig/CHANGELOG.md
@@ -4,7 +4,7 @@ CHANGELOG
 4.3.0
 -----
 
- * added the `parent_form()` function that allows to reliably retrieve the parent form in Twig templates
+ * added the `form_parent()` function that allows to reliably retrieve the parent form in Twig templates
 
 4.2.0
 -----
diff --git a/src/Symfony/Bridge/Twig/Extension/FormExtension.php b/src/Symfony/Bridge/Twig/Extension/FormExtension.php
@@ -54,7 +54,7 @@ public function getFunctions()
             new TwigFunction('form_start', null, ['node_class' => 'Symfony\Bridge\Twig\Node\RenderBlockNode', 'is_safe' => ['html']]),
             new TwigFunction('form_end', null, ['node_class' => 'Symfony\Bridge\Twig\Node\RenderBlockNode', 'is_safe' => ['html']]),
             new TwigFunction('csrf_token', ['Symfony\Component\Form\FormRenderer', 'renderCsrfToken']),
-            new TwigFunction('parent_form', 'Symfony\Bridge\Twig\Extension\twig_get_parent_form'),
+            new TwigFunction('form_parent', 'Symfony\Bridge\Twig\Extension\twig_get_form_parent'),
         ];
     }
 
@@ -120,7 +120,7 @@ function twig_is_root_form(FormView $formView)
 /**
  * @internal
  */
-function twig_get_parent_form(FormView $formView): ?FormView
+function twig_get_form_parent(FormView $formView): ?FormView
 {
     return $formView->parent;
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function getFunctions()`
`54`	`54`	`new TwigFunction('form_start', null, ['node_class' => 'Symfony\Bridge\Twig\Node\RenderBlockNode', 'is_safe' => ['html']]),`
`55`	`55`	`new TwigFunction('form_end', null, ['node_class' => 'Symfony\Bridge\Twig\Node\RenderBlockNode', 'is_safe' => ['html']]),`
`56`	`56`	`new TwigFunction('csrf_token', ['Symfony\Component\Form\FormRenderer', 'renderCsrfToken']),`
`57`		`- new TwigFunction('parent_form', 'Symfony\Bridge\Twig\Extension\twig_get_parent_form'),`
	`57`	`+ new TwigFunction('form_parent', 'Symfony\Bridge\Twig\Extension\twig_get_form_parent'),`
`58`	`58`	`];`
`59`	`59`	`}`
`60`	`60`
`@@ -120,7 +120,7 @@ function twig_is_root_form(FormView $formView)`
`120`	`120`	`/**`
`121`	`121`	`* @internal`
`122`	`122`	`*/`
`123`		`-function twig_get_parent_form(FormView $formView): ?FormView`
	`123`	`+function twig_get_form_parent(FormView $formView): ?FormView`
`124`	`124`	`{`
`125`	`125`	`return $formView->parent;`
`126`	`126`	`}`