Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes"

Emmanuel BORGES · Emmanuel BORGES · commit 606d8d370da3 · 2019-03-27T09:43:12.000+01:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php
@@ -109,7 +109,7 @@ protected function extractAttributes($object, $format = null, array $context = [
 
             $attributeName = lcfirst(substr($method->name, 0 === strpos($method->name, 'is') ? 2 : 3));
 
-            if ($this->isAllowedAttribute($object, $attributeName)) {
+            if ($this->isAllowedAttribute($object, $attributeName, $format, $context)) {
                 $attributes[] = $attributeName;
             }
         }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/GetSetMethodNormalizerTest.php
@@ -91,6 +91,23 @@ public function testDenormalize()
         $this->assertTrue($obj->isBaz());
     }
 
+    public function testIgnoredAttributesInContext()
+    {
+        $ignoredAttributes = ['foo', 'bar', 'baz', 'object'];
+        $this->normalizer->setIgnoredAttributes($ignoredAttributes);
+        $obj = new GetSetDummy();
+        $obj->setFoo('foo');
+        $obj->setBar('bar');
+        $obj->setCamelCase(true);
+        $this->assertEquals(
+            [
+                'fooBar' => 'foobar',
+                'camelCase' => true,
+            ],
+            $this->normalizer->normalize($obj, 'any')
+        );
+    }
+
     public function testDenormalizeWithObject()
     {
         $data = new \stdClass();

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ protected function extractAttributes($object, $format = null, array $context = [`
`109`	`109`
`110`	`110`	`$attributeName = lcfirst(substr($method->name, 0 === strpos($method->name, 'is') ? 2 : 3));`
`111`	`111`
`112`		`- if ($this->isAllowedAttribute($object, $attributeName)) {`
	`112`	`+ if ($this->isAllowedAttribute($object, $attributeName, $format, $context)) {`
`113`	`113`	`$attributes[] = $attributeName;`
`114`	`114`	`}`
`115`	`115`	`}`