bug #46291 [Console] Suppress unhandled error in some specific use-cases. (rw4lll)

nicolas-grekas · nicolas-grekas · commit 60836ff4c3cb · 2022-05-10T10:11:00.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Suppress unhandled error in some specific use-cases. | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  If the package is used not in console with open_basedir enabled, since 5.4 it fails with unhandled php error here: (https://github.com/symfony/console/blob/06974380c667d7d8e3cd0f24bf51f816a71ca6c6/Command/DumpCompletionCommand.php#L44) because of trying to call realpath("/") and, of course, it's not allowed. It's a very specific use-case for Symfony, but can happen if it's used as dependency, e.g. in Laravel. I've described it in details here: laravel/framework#42171 I think that the best would be just suppress the error in that case. Commits ------- d975ca7 Suppress unhandled error in some specific use-cases.
diff --git a/src/Symfony/Component/Console/Command/DumpCompletionCommand.php b/src/Symfony/Component/Console/Command/DumpCompletionCommand.php
@@ -41,7 +41,7 @@ protected function configure()
     {
         $fullCommand = $_SERVER['PHP_SELF'];
         $commandName = basename($fullCommand);
-        $fullCommand = realpath($fullCommand) ?: $fullCommand;
+        $fullCommand = @realpath($fullCommand) ?: $fullCommand;
 
         $this
             ->setHelp(<<<EOH

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ protected function configure()`
`41`	`41`	`{`
`42`	`42`	`$fullCommand = $_SERVER['PHP_SELF'];`
`43`	`43`	`$commandName = basename($fullCommand);`
`44`		`- $fullCommand = realpath($fullCommand) ?: $fullCommand;`
	`44`	`+ $fullCommand = @realpath($fullCommand) ?: $fullCommand;`
`45`	`45`
`46`	`46`	`$this`
`47`	`47`	`->setHelp(<<<EOH`