bug #53521 [VarDumper] Fixes Typed property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initialization (crynobone)

fabpot · fabpot · commit 63d9a53ce403 · 2024-01-12T14:22:11.000+01:00
This PR was squashed before being merged into the 7.0 branch. Discussion ---------- [VarDumper] Fixes `Typed property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initialization` | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Issues | N/A | License | MIT Fixes the following error: ![CleanShot 2024-01-12 at 16 27 25](https://github.com/symfony/symfony/assets/172966/dfb482ff-4754-41cd-bc06-36143afad5cb) Other methods in the class start with `$this->colors ??= $this->supportsColors();`. I believe this should have the same code. Commits ------- b163c7a [VarDumper] Fixes `Typed property Symfony\Component\VarDumper\Dumper\CliDumper::$colors must not be accessed before initialization`
diff --git a/src/Symfony/Component/VarDumper/Dumper/CliDumper.php b/src/Symfony/Component/VarDumper/Dumper/CliDumper.php
@@ -550,7 +550,7 @@ protected function supportsColors(): bool
 
     protected function dumpLine(int $depth, bool $endOfValue = false): void
     {
-        if ($this->colors) {
+        if ($this->colors ??= $this->supportsColors()) {
             $this->line = sprintf("\033[%sm%s\033[m", $this->styles['default'], $this->line);
         }
         parent::dumpLine($depth);

Original file line number	Diff line number	Diff line change
`@@ -550,7 +550,7 @@ protected function supportsColors(): bool`
`550`	`550`
`551`	`551`	`protected function dumpLine(int $depth, bool $endOfValue = false): void`
`552`	`552`	`{`
`553`		`- if ($this->colors) {`
	`553`	`+ if ($this->colors ??= $this->supportsColors()) {`
`554`	`554`	`$this->line = sprintf("\033[%sm%s\033[m", $this->styles['default'], $this->line);`
`555`	`555`	`}`
`556`	`556`	`parent::dumpLine($depth);`