Add context variable to enable/disable this

jewome62 · jewome62 · commit 63de18f0e95c · 2019-12-11T15:11:02.000+01:00
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -3,7 +3,7 @@ CHANGELOG
 
 5.1.0
 -----
- * Cast to PHP type numeric value from node for XML
+ * Cast to PHP type numeric value from node for XML if `XmlEncoder::TYPE_CAST_NODES` set to true into context
 
 5.0.0
 -----
diff --git a/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php b/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
@@ -52,6 +52,7 @@ class XmlEncoder implements EncoderInterface, DecoderInterface, NormalizationAwa
     const ROOT_NODE_NAME = 'xml_root_node_name';
     const STANDALONE = 'xml_standalone';
     const TYPE_CAST_ATTRIBUTES = 'xml_type_cast_attributes';
+    const TYPE_CAST_NODES = 'xml_type_cast_nodes';
     const VERSION = 'xml_version';
 
     private $defaultContext = [
@@ -62,6 +63,7 @@ class XmlEncoder implements EncoderInterface, DecoderInterface, NormalizationAwa
         self::REMOVE_EMPTY_TAGS => false,
         self::ROOT_NODE_NAME => 'response',
         self::TYPE_CAST_ATTRIBUTES => true,
+        self::TYPE_CAST_NODES => true,
     ];
 
     /**
@@ -325,16 +327,18 @@ private function parseXmlValue(\DOMNode $node, array $context = [])
             return $node->nodeValue;
         }
 
+        $typeCastNodes = (bool) ($context[self::TYPE_CAST_NODES] ?? $this->defaultContext[self::TYPE_CAST_NODES]);
+
         if (1 === $node->childNodes->length && \in_array($node->firstChild->nodeType, [XML_TEXT_NODE, XML_CDATA_SECTION_NODE])) {
-            if (false !== $val = filter_var($node->firstChild->nodeValue, FILTER_VALIDATE_INT)) {
-                return $val;
+            if (!is_numeric($node->firstChild->nodeValue) || !$typeCastNodes) {
+                return $node->firstChild->nodeValue;
             }
 
-            if (false !== $val = filter_var($node->firstChild->nodeValue, FILTER_VALIDATE_FLOAT)) {
+            if (false !== $val = filter_var($node->firstChild->nodeValue, FILTER_VALIDATE_INT)) {
                 return $val;
             }
 
-            return $node->firstChild->nodeValue;
+            return (float) $node->firstChild->nodeValue;
         }
 
         $value = [];
