check permissions if dump target dir is missing

xabbuh · xabbuh · commit 64b390a70493 · 2017-09-05T21:23:37.000+02:00
`is_dir()` returns `false` if the parent directory misses the executable
bit even when the directory itself is present.
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -532,6 +532,16 @@ public function dumpFile($filename, $content, $mode = 0666)
         $dir = dirname($filename);
 
         if (!is_dir($dir)) {
+            $oldCwd = getcwd();
+
+            if (!@chdir(dirname($dir))) {
+                // The target directory may exists, but we are unable to make a decision as we lack proper permissions
+                // to enter its parent directory.
+                throw new IOException(sprintf('Unable to detect if the target directory "%s" exists.', $dir));
+            }
+
+            chdir($oldCwd);
+
             $this->mkdir($dir);
         }
 
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -1102,6 +1102,22 @@ public function testDumpKeepsExistingPermissionsWhenOverwritingAnExistingFile()
         $this->assertFilePermissions(745, $filename);
     }
 
+    /**
+     * @expectedException \Symfony\Component\Filesystem\Exception\IOException
+     * @expectedExceptionMessageRegExp /^Unable to detect if the target directory ".*" exists\.$/
+     */
+    public function testDumpFailsWithExceptionIfExecutablePermissionsForTheParentDirectoryAreMissing()
+    {
+        $this->markAsSkippedIfChmodIsMissing();
+
+        $target = $this->workspace.DIRECTORY_SEPARATOR.'foo';
+        $file = $target.DIRECTORY_SEPARATOR.'foobar';
+        mkdir($target);
+        chmod($this->workspace, 0666);
+
+        $this->filesystem->dumpFile($file, 'baz');
+    }
+
     public function testCopyShouldKeepExecutionPermission()
     {
         $this->markAsSkippedIfChmodIsMissing();
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTestCase.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTestCase.php
@@ -61,6 +61,7 @@ protected function tearDown()
             $this->longPathNamesWindows = array();
         }
 
+        chmod($this->workspace, 0777);
         $this->filesystem->remove($this->workspace);
         umask($this->umask);
     }

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ protected function tearDown()`
`61`	`61`	`$this->longPathNamesWindows = array();`
`62`	`62`	`}`
`63`	`63`
	`64`	`+ chmod($this->workspace, 0777);`
`64`	`65`	`$this->filesystem->remove($this->workspace);`
`65`	`66`	`umask($this->umask);`
`66`	`67`	`}`