feature #20047 [Form] Change FormTypeGuesserChain to accept Traversable (enumag)

fabpot · fabpot · commit 650f6d1ea5d5 · 2016-10-19T15:12:03.000-07:00
This PR was merged into the 3.2-dev branch. Discussion ---------- [Form] Change FormTypeGuesserChain to accept Traversable | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I'm using symfony/form without the rest of the framework and this will make things a bit easier for me. Commits ------- 5e4f4d4 [Form] Change FormTypeGuesserChain to accept Traversable
diff --git a/src/Symfony/Component/Form/FormTypeGuesserChain.php b/src/Symfony/Component/Form/FormTypeGuesserChain.php
@@ -25,8 +25,12 @@ class FormTypeGuesserChain implements FormTypeGuesserInterface
      *
      * @throws UnexpectedTypeException if any guesser does not implement FormTypeGuesserInterface
      */
-    public function __construct(array $guessers)
+    public function __construct($guessers)
     {
+        if (!is_array($guessers) && !$guessers instanceof \Traversable) {
+            throw new UnexpectedTypeException($guessers, 'array or Traversable');
+        }
+
         foreach ($guessers as $guesser) {
             if (!$guesser instanceof FormTypeGuesserInterface) {
                 throw new UnexpectedTypeException($guesser, 'Symfony\Component\Form\FormTypeGuesserInterface');

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,12 @@ class FormTypeGuesserChain implements FormTypeGuesserInterface`
`25`	`25`	`*`
`26`	`26`	`* @throws UnexpectedTypeException if any guesser does not implement FormTypeGuesserInterface`
`27`	`27`	`*/`
`28`		`- public function __construct(array $guessers)`
	`28`	`+ public function __construct($guessers)`
`29`	`29`	`{`
	`30`	`+ if (!is_array($guessers) && !$guessers instanceof \Traversable) {`
	`31`	`+ throw new UnexpectedTypeException($guessers, 'array or Traversable');`
	`32`	`+ }`
	`33`	`+`
`30`	`34`	`foreach ($guessers as $guesser) {`
`31`	`35`	`if (!$guesser instanceof FormTypeGuesserInterface) {`
`32`	`36`	`throw new UnexpectedTypeException($guesser, 'Symfony\Component\Form\FormTypeGuesserInterface');`