bug #26358 [FrameworkBundle] Silence "Failed to remove directory" on cache:clear (nicolas-grekas)

fabpot · fabpot · commit 6628318b290e · 2018-03-01T12:19:29.000-08:00
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Silence "Failed to remove directory" on cache:clear | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #2600 | License | MIT | Doc PR | - Let's improve the experience of ppl (see old linked issue). This warning is just noise to most. Commits ------- 3ba624a [FrameworkBundle] Silence "Failed to remove directory" on cache:clear
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php
@@ -156,7 +156,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
         try {
             $fs->remove($oldCacheDir);
         } catch (IOException $e) {
-            $io->warning($e->getMessage());
+            if ($output->isVerbose()) {
+                $io->warning($e->getMessage());
+            }
         }
 
         if ($output->isVerbose()) {
