minor #36689 [Yaml] properly handle empty lines (xabbuh)

nicolas-grekas · nicolas-grekas · commit 6852327eee2c · 2020-05-04T18:38:20.000+02:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [Yaml] properly handle empty lines | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- e91bb61 properly handle empty lines
diff --git a/src/Symfony/Component/Yaml/Parser.php b/src/Symfony/Component/Yaml/Parser.php
@@ -969,7 +969,7 @@ private function isCurrentLineBlank(): bool
     private function isCurrentLineComment(): bool
     {
         //checking explicitly the first char of the trim is faster than loops or strpos
-        $ltrimmedLine = ' ' === $this->currentLine[0] ? ltrim($this->currentLine, ' ') : $this->currentLine;
+        $ltrimmedLine = '' !== $this->currentLine && ' ' === $this->currentLine[0] ? ltrim($this->currentLine, ' ') : $this->currentLine;
 
         return '' !== $ltrimmedLine && '#' === $ltrimmedLine[0];
     }

Original file line number	Diff line number	Diff line change
`@@ -969,7 +969,7 @@ private function isCurrentLineBlank(): bool`
`969`	`969`	`private function isCurrentLineComment(): bool`
`970`	`970`	`{`
`971`	`971`	`//checking explicitly the first char of the trim is faster than loops or strpos`
`972`		`- $ltrimmedLine = ' ' === $this->currentLine[0] ? ltrim($this->currentLine, ' ') : $this->currentLine;`
	`972`	`+ $ltrimmedLine = '' !== $this->currentLine && ' ' === $this->currentLine[0] ? ltrim($this->currentLine, ' ') : $this->currentLine;`
`973`	`973`
`974`	`974`	`return '' !== $ltrimmedLine && '#' === $ltrimmedLine[0];`
`975`	`975`	`}`