[Console] ensure exit code between 0-254

Tobion · Tobion · commit 6b9180a23ded · 2013-06-09T14:59:14.000+02:00
255 is reserved by PHP and should not be used

also put this code inside the codeCoverageIgnore block because it cannot be tested with phpunit
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -126,11 +126,9 @@ public function run(InputInterface $input = null, OutputInterface $output = null
         }
 
         if ($this->autoExit) {
-            if ($statusCode > 255) {
-                $statusCode = 255;
-            }
+            // ensure exit code is between 0-254 (255 is reserved by PHP and should not be used)
             // @codeCoverageIgnoreStart
-            exit($statusCode);
+            exit(max(0, min(254, $statusCode)));
             // @codeCoverageIgnoreEnd
         }
 

Original file line number	Diff line number	Diff line change
`@@ -126,11 +126,9 @@ public function run(InputInterface $input = null, OutputInterface $output = null`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`if ($this->autoExit) {`
`129`		`- if ($statusCode > 255) {`
`130`		`- $statusCode = 255;`
`131`		`- }`
	`129`	`+ // ensure exit code is between 0-254 (255 is reserved by PHP and should not be used)`
`132`	`130`	`// @codeCoverageIgnoreStart`
`133`		`- exit($statusCode);`
	`131`	`+ exit(max(0, min(254, $statusCode)));`
`134`	`132`	`// @codeCoverageIgnoreEnd`
`135`	`133`	`}`
`136`	`134`