ensure string type with mbstring func overloading enabled

xabbuh · xabbuh · commit 6cef1672aecc · 2023-11-06T22:20:36.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/HeaderUtils.php b/src/Symfony/Component/HttpFoundation/HeaderUtils.php
@@ -256,7 +256,7 @@ public static function parseQuery(string $query, bool $ignoreBrackets = false, s
     private static function groupParts(array $matches, string $separators, bool $first = true): array
     {
         $separator = $separators[0];
-        $separators = substr($separators, 1);
+        $separators = substr($separators, 1) ?: '';
         $i = 0;
 
         if ('' === $separators && !$first) {
diff --git a/src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php
@@ -32,6 +32,13 @@ public function testCreate()
         $this->assertEquals('bar', $response->headers->get('foo'));
     }
 
+    public function testCreateWithoutConstructorArguments()
+    {
+        new Response();
+
+        $this->fail('this should not be reached');
+    }
+
     public function testToString()
     {
         $response = new Response();

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ public static function parseQuery(string $query, bool $ignoreBrackets = false, s`
`256`	`256`	`private static function groupParts(array $matches, string $separators, bool $first = true): array`
`257`	`257`	`{`
`258`	`258`	`$separator = $separators[0];`
`259`		`- $separators = substr($separators, 1);`
	`259`	`+ $separators = substr($separators, 1) ?: '';`
`260`	`260`	`$i = 0;`
`261`	`261`
`262`	`262`	`if ('' === $separators && !$first) {`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,13 @@ public function testCreate()`
`32`	`32`	`$this->assertEquals('bar', $response->headers->get('foo'));`
`33`	`33`	`}`
`34`	`34`
	`35`	`+ public function testCreateWithoutConstructorArguments()`
	`36`	`+ {`
	`37`	`+ new Response();`
	`38`	`+`
	`39`	`+ $this->fail('this should not be reached');`
	`40`	`+ }`
	`41`	`+`
`35`	`42`	`public function testToString()`
`36`	`43`	`{`
`37`	`44`	`$response = new Response();`