Revamp LDAP options with nested definition

yceruto · yceruto · commit 73c3f387d5c9 · 2018-10-12T11:24:05.000-04:00
diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php
@@ -93,31 +93,17 @@ protected function configureOptions(OptionsResolver $resolver)
         $resolver->setAllowedTypes('debug', 'bool');
         $resolver->setDefault('referrals', false);
         $resolver->setAllowedTypes('referrals', 'bool');
+        $resolver->setDefault('options', function (OptionsResolver $options, Options $parent) {
+            $options->setDefined(array_map('strtolower', array_keys((new \ReflectionClass(ConnectionOptions::class))->getConstants())));
 
-        $resolver->setNormalizer('options', function (Options $options, $value) {
-            if (true === $options['debug']) {
-                $value['debug_level'] = 7;
+            if (true === $parent['debug']) {
+                $options->setDefault('debug_level', 7);
             }
 
-            if (!isset($value['protocol_version'])) {
-                $value['protocol_version'] = $options['version'];
-            }
-
-            if (!isset($value['referrals'])) {
-                $value['referrals'] = $options['referrals'];
-            }
-
-            return $value;
-        });
-
-        $resolver->setAllowedValues('options', function (array $values) {
-            foreach ($values as $name => $value) {
-                if (!ConnectionOptions::isOption($name)) {
-                    return false;
-                }
-            }
-
-            return true;
+            $options->setDefaults([
+                'protocol_version' => $parent['version'],
+                'referrals' => $parent['referrals'],
+            ]);
         });
     }
 
diff --git a/src/Symfony/Component/Ldap/composer.json b/src/Symfony/Component/Ldap/composer.json
@@ -17,9 +17,12 @@
     ],
     "require": {
         "php": "^7.1.3",
-        "symfony/options-resolver": "~3.4|~4.0",
+        "symfony/options-resolver": "~4.2",
         "ext-ldap": "*"
     },
+    "conflict": {
+        "symfony/options-resolver": "<4.2"
+    },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Ldap\\": "" },
         "exclude-from-classmap": [
