bug #48359 [VarDumper] Ignore \Error in __debugInfo() (fancyweb)

fabpot · fabpot · commit 75f8547d118c · 2022-12-09T08:30:39.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [VarDumper] Ignore \Error in __debugInfo() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - `__debugInfo()` can throw `\TypeError` (the test case is from a real vendor doing that 😅) Commits ------- cc5ab14 [VarDumper] Ignore \Error in __debugInfo()
diff --git a/src/Symfony/Component/VarDumper/Caster/Caster.php b/src/Symfony/Component/VarDumper/Caster/Caster.php
@@ -47,7 +47,7 @@ public static function castObject(object $obj, string $class, bool $hasDebugInfo
         if ($hasDebugInfo) {
             try {
                 $debugInfo = $obj->__debugInfo();
-            } catch (\Exception $e) {
+            } catch (\Throwable $e) {
                 // ignore failing __debugInfo()
                 $hasDebugInfo = false;
             }
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/CasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/CasterTest.php
@@ -175,4 +175,14 @@ public function testAnonymousClass()
             , $c
         );
     }
+
+    public function testTypeErrorInDebugInfo()
+    {
+        $this->assertDumpMatchesFormat('class@anonymous {}', new class() {
+            public function __debugInfo(): array
+            {
+                return ['class' => \get_class(null)];
+            }
+        });
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public static function castObject(object $obj, string $class, bool $hasDebugInfo`
`47`	`47`	`if ($hasDebugInfo) {`
`48`	`48`	`try {`
`49`	`49`	`$debugInfo = $obj->__debugInfo();`
`50`		`- } catch (\Exception $e) {`
	`50`	`+ } catch (\Throwable $e) {`
`51`	`51`	`// ignore failing __debugInfo()`
`52`	`52`	`$hasDebugInfo = false;`
`53`	`53`	`}`