Fix issues raised by comments

dunglas · dunglas · commit 766b6402c382 · 2016-07-10T10:42:56.000+02:00
diff --git a/src/Symfony/Bundle/SecurityBundle/Resources/config/security_listeners.xml b/src/Symfony/Bundle/SecurityBundle/Resources/config/security_listeners.xml
@@ -150,7 +150,7 @@
             <argument /> <!-- Provider-shared Key -->
             <argument type="service" id="security.authentication.success_handler" />
             <argument type="service" id="security.authentication.failure_handler" />
-            <argument type="collection" />
+            <argument type="collection" /> <!-- Options -->
             <argument type="service" id="logger" on-invalid="null" />
             <argument type="service" id="event_dispatcher" on-invalid="null" />
             <argument type="service" id="property_accessor" on-invalid="null" />
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/JsonLoginBundle/Controller/TestController.php b/src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/JsonLoginBundle/Controller/TestController.php
@@ -18,6 +18,6 @@ class TestController
 {
     public function loginCheckAction()
     {
-        throw new \RuntimeException('loginAction() should never be called.');
+        throw new \RuntimeException(sprintf('%s should never be called.', __FUNCTION__));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,6 @@ class TestController`
`18`	`18`	`{`
`19`	`19`	`public function loginCheckAction()`
`20`	`20`	`{`
`21`		`- throw new \RuntimeException('loginAction() should never be called.');`
	`21`	`+ throw new \RuntimeException(sprintf('%s should never be called.', __FUNCTION__));`
`22`	`22`	`}`
`23`	`23`	`}`