minor #57642 [Routing] Remove dead is_object() check (derrabus)

derrabus · derrabus · commit 79165a481d7b · 2024-07-04T11:53:58.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [Routing] Remove dead `is_object()` check | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Right after we call `ObjectLoader::getObject()`, we check if the returned value is actually an object. Since 6.0 (#42509), that method has a native return type of `object`, so we can be pretty sure that we won't ever not hold an object in our hands here. Commits ------- f734932 [Router] Remove dead is_object() check
diff --git a/src/Symfony/Component/Routing/Loader/ObjectLoader.php b/src/Symfony/Component/Routing/Loader/ObjectLoader.php
@@ -44,10 +44,6 @@ public function load(mixed $resource, ?string $type = null): RouteCollection
 
         $loaderObject = $this->getObject($parts[0]);
 
-        if (!\is_object($loaderObject)) {
-            throw new \TypeError(\sprintf('"%s:getObject()" must return an object: "%s" returned.', static::class, get_debug_type($loaderObject)));
-        }
-
         if (!\is_callable([$loaderObject, $method])) {
             throw new \BadMethodCallException(\sprintf('Method "%s" not found on "%s" when importing routing resource "%s".', $method, get_debug_type($loaderObject), $resource));
         }

Original file line number	Diff line number	Diff line change
`@@ -44,10 +44,6 @@ public function load(mixed $resource, ?string $type = null): RouteCollection`
`44`	`44`
`45`	`45`	`$loaderObject = $this->getObject($parts[0]);`
`46`	`46`
`47`		`- if (!\is_object($loaderObject)) {`
`48`		`- throw new \TypeError(\sprintf('"%s:getObject()" must return an object: "%s" returned.', static::class, get_debug_type($loaderObject)));`
`49`		`- }`
`50`		`-`
`51`	`47`	`if (!\is_callable([$loaderObject, $method])) {`
`52`	`48`	`throw new \BadMethodCallException(\sprintf('Method "%s" not found on "%s" when importing routing resource "%s".', $method, get_debug_type($loaderObject), $resource));`
`53`	`49`	`}`