fix case when there is no failure transport defined

monteiro · monteiro · commit 7ae1176841b0 · 2019-12-29T07:41:12.000Z
diff --git a/src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php b/src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php
@@ -41,6 +41,10 @@ public function onMessageFailed(WorkerMessageFailedEvent $event)
             return;
         }
 
+        if (!isset($this->failureSenders[$event->getReceiverName()])) {
+            return;
+        }
+
         $envelope = $event->getEnvelope();
 
         // avoid re-sending to the failed sender
diff --git a/src/Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageToFailureTransportListenerTest.php b/src/Symfony/Component/Messenger/Tests/EventListener/SendFailedMessageToFailureTransportListenerTest.php
@@ -22,6 +22,20 @@
 
 class SendFailedMessageToFailureTransportListenerTest extends TestCase
 {
+    public function testDoNothingIfFailureTransportIsNotDefined()
+    {
+        $sender = $this->createMock(SenderInterface::class);
+        $sender->expects($this->never())->method('send');
+
+        $listener = new SendFailedMessageToFailureTransportListener([]);
+
+        $exception = new \Exception('no!');
+        $envelope = new Envelope(new \stdClass());
+        $event = new WorkerMessageFailedEvent($envelope, 'my_receiver', $exception);
+
+        $listener->onMessageFailed($event);
+    }
+
     public function testItSendsToTheFailureTransport()
     {
         $sender = $this->createMock(SenderInterface::class);

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,10 @@ public function onMessageFailed(WorkerMessageFailedEvent $event)`
`41`	`41`	`return;`
`42`	`42`	`}`
`43`	`43`
	`44`	`+ if (!isset($this->failureSenders[$event->getReceiverName()])) {`
	`45`	`+ return;`
	`46`	`+ }`
	`47`	`+`
`44`	`48`	`$envelope = $event->getEnvelope();`
`45`	`49`
`46`	`50`	`// avoid re-sending to the failed sender`