[Serializer] Re-add AdvancedNameConverterInterface as deprecated

mtarld · mtarld · commit 7d989bcad3aa · 2024-09-18T19:09:25.000+02:00
diff --git a/UPGRADE-7.1.md b/UPGRADE-7.1.md
@@ -214,6 +214,7 @@ SecurityBundle
 Serializer
 ----------
 
+ * Deprecate `AdvancedNameConverterInterface`, use `NameConverterInterface` instead
  * Deprecate the `withDefaultContructorArguments()` method of `AbstractNormalizerContextBuilder`, use `withDefaultConstructorArguments()` instead (note the typo in the old method name)
 
 Translation
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 7.1
 ---
 
+ * Deprecate `AdvancedNameConverterInterface`, use `NameConverterInterface` instead
  * Add arguments `$class`, `$format` and `$context` to `NameConverterInterface::normalize()` and `NameConverterInterface::denormalize()`
  * Add `DateTimeNormalizer::CAST_KEY` context option
  * Add `Default` and "class name" default groups
diff --git a/src/Symfony/Component/Serializer/NameConverter/AdvancedNameConverterInterface.php b/src/Symfony/Component/Serializer/NameConverter/AdvancedNameConverterInterface.php
@@ -15,6 +15,8 @@
  * Gives access to the class, the format and the context in the property name converters.
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
+ *
+ * @deprecated since Symfony 7.1, use NameConverterInterface instead
  */
 interface AdvancedNameConverterInterface extends NameConverterInterface
 {
diff --git a/src/Symfony/Component/Serializer/NameConverter/CamelCaseToSnakeCaseNameConverter.php b/src/Symfony/Component/Serializer/NameConverter/CamelCaseToSnakeCaseNameConverter.php
@@ -19,7 +19,7 @@
  * @author Kévin Dunglas <dunglas@gmail.com>
  * @author Aurélien Pillevesse <aurelienpillevesse@hotmail.fr>
  */
-class CamelCaseToSnakeCaseNameConverter implements NameConverterInterface
+class CamelCaseToSnakeCaseNameConverter implements NameConverterInterface, AdvancedNameConverterInterface
 {
     /**
      * Require all properties to be written in snake_case.
@@ -41,7 +41,7 @@ public function __construct(
      * @param string|null          $format
      * @param array<string, mixed> $context
      */
-    public function normalize(string $propertyName/* , ?string $class = null, ?string $format = null, array $context = [] */): string
+    public function normalize(string $propertyName, ?string $class = null, ?string $format = null, array $context = []): string
     {
         if (null === $this->attributes || \in_array($propertyName, $this->attributes, true)) {
             return strtolower(preg_replace('/[A-Z]/', '_\\0', lcfirst($propertyName)));
@@ -55,12 +55,8 @@ public function normalize(string $propertyName/* , ?string $class = null, ?strin
      * @param string|null          $format
      * @param array<string, mixed> $context
      */
-    public function denormalize(string $propertyName/* , ?string $class = null, ?string $format = null, array $context = [] */): string
+    public function denormalize(string $propertyName, ?string $class = null, ?string $format = null, array $context = []): string
     {
-        $class = 1 < \func_num_args() ? func_get_arg(1) : null;
-        $format = 2 < \func_num_args() ? func_get_arg(2) : null;
-        $context = 3 < \func_num_args() ? func_get_arg(3) : [];
-
         if (($context[self::REQUIRE_SNAKE_CASE_PROPERTIES] ?? false) && $propertyName !== $this->normalize($propertyName, $class, $format, $context)) {
             throw new UnexpectedPropertyException($propertyName);
         }
diff --git a/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php b/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php
@@ -18,7 +18,7 @@
 /**
  * @author Fabien Bourigault <bourigaultfabien@gmail.com>
  */
-final class MetadataAwareNameConverter implements NameConverterInterface
+final class MetadataAwareNameConverter implements NameConverterInterface, AdvancedNameConverterInterface
 {
     /**
      * @var array<string, array<string, string|null>>

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`	`* Gives access to the class, the format and the context in the property name converters.`
`16`	`16`	`*`
`17`	`17`	`* @author Kévin Dunglas <[email protected]>`
	`18`	`+ *`
	`19`	`+ * @deprecated since Symfony 7.1, use NameConverterInterface instead`
`18`	`20`	`*/`
`19`	`21`	`interface AdvancedNameConverterInterface extends NameConverterInterface`
`20`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`/**`
`19`	`19`	`* @author Fabien Bourigault <[email protected]>`
`20`	`20`	`*/`
`21`		`-final class MetadataAwareNameConverter implements NameConverterInterface`
	`21`	`+final class MetadataAwareNameConverter implements NameConverterInterface, AdvancedNameConverterInterface`
`22`	`22`	`{`
`23`	`23`	`/**`
`24`	`24`	`* @var array<string, array<string, string\|null>>`