bug #41402 [HttpKernel] Throw when HttpKernel is created and the env is empty (nicolas-grekas)

fabpot · fabpot · commit 7e9dbeca2900 · 2021-05-24T19:52:36.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [HttpKernel] Throw when HttpKernel is created and the env is empty | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Providing an empty env leads to an undefined behavior, better forbid it. This will fail at compile time, so it should be safe; but still submitting on 5.3 for extra safety. Commits ------- 1a87f26 [HttpKernel] Throw when HttpKernel is created and the env is empty
diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php
@@ -87,7 +87,10 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl
 
     public function __construct(string $environment, bool $debug)
     {
-        $this->environment = $environment;
+        if (!$this->environment = $environment) {
+            throw new \InvalidArgumentException(sprintf('Invalid environment provided to "%s": the environment cannot be empty.', get_debug_type($this)));
+        }
+
         $this->debug = $debug;
     }
 
diff --git a/src/Symfony/Component/HttpKernel/Tests/KernelTest.php b/src/Symfony/Component/HttpKernel/Tests/KernelTest.php
@@ -55,6 +55,14 @@ public function testConstructor()
         $this->assertLessThanOrEqual(microtime(true), $kernel->getStartTime());
     }
 
+    public function testEmptyEnv()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage(sprintf('Invalid environment provided to "%s": the environment cannot be empty.', KernelForTest::class));
+
+        new KernelForTest('', false);
+    }
+
     public function testClone()
     {
         $env = 'test_env';

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,10 @@ abstract class Kernel implements KernelInterface, RebootableInterface, Terminabl`
`87`	`87`
`88`	`88`	`public function __construct(string $environment, bool $debug)`
`89`	`89`	`{`
`90`		`- $this->environment = $environment;`
	`90`	`+ if (!$this->environment = $environment) {`
	`91`	`+ throw new \InvalidArgumentException(sprintf('Invalid environment provided to "%s": the environment cannot be empty.', get_debug_type($this)));`
	`92`	`+ }`
	`93`	`+`
`91`	`94`	`$this->debug = $debug;`
`92`	`95`	`}`
`93`	`96`
Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,14 @@ public function testConstructor()`
`55`	`55`	`$this->assertLessThanOrEqual(microtime(true), $kernel->getStartTime());`
`56`	`56`	`}`
`57`	`57`
	`58`	`+ public function testEmptyEnv()`
	`59`	`+ {`
	`60`	`+ $this->expectException(\InvalidArgumentException::class);`
	`61`	`+ $this->expectExceptionMessage(sprintf('Invalid environment provided to "%s": the environment cannot be empty.', KernelForTest::class));`
	`62`	`+`
	`63`	`+ new KernelForTest('', false);`
	`64`	`+ }`
	`65`	`+`
`58`	`66`	`public function testClone()`
`59`	`67`	`{`
`60`	`68`	`$env = 'test_env';`