bug #52927 [Dotenv] Properly handle SYMFONY_DOTENV_VARS being the empty string (xabbuh)

fabpot · fabpot · commit 7f778ac6394b · 2023-12-08T14:44:46.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Dotenv] Properly handle `SYMFONY_DOTENV_VARS` being the empty string | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- dfe7e1b properly handle SYMFONY_DOTENV_VARS being the empty string
diff --git a/src/Symfony/Component/Dotenv/Command/DebugCommand.php b/src/Symfony/Component/Dotenv/Command/DebugCommand.php
@@ -82,7 +82,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
     private function getVariables(array $envFiles): array
     {
-        $vars = explode(',', $_SERVER['SYMFONY_DOTENV_VARS'] ?? '');
+        $dotenvVars = $_SERVER['SYMFONY_DOTENV_VARS'] ?? '';
+
+        if ('' === $dotenvVars) {
+            return [];
+        }
+
+        $vars = explode(',', $dotenvVars);
         sort($vars);
 
         $output = [];
diff --git a/src/Symfony/Component/Dotenv/Tests/Command/DebugCommandTest.php b/src/Symfony/Component/Dotenv/Tests/Command/DebugCommandTest.php
@@ -25,6 +25,8 @@ class DebugCommandTest extends TestCase
      */
     public function testErrorOnUninitializedDotenv()
     {
+        unset($_SERVER['SYMFONY_DOTENV_VARS']);
+
         $command = new DebugCommand('dev', __DIR__.'/Fixtures/Scenario1');
         $command->setHelperSet(new HelperSet([new FormatterHelper()]));
         $tester = new CommandTester($command);
@@ -34,6 +36,30 @@ public function testErrorOnUninitializedDotenv()
         $this->assertStringContainsString('[ERROR] Dotenv component is not initialized', $output);
     }
 
+    /**
+     * @runInSeparateProcess
+     */
+    public function testEmptyDotEnvVarsList()
+    {
+        $_SERVER['SYMFONY_DOTENV_VARS'] = '';
+
+        $command = new DebugCommand('dev', __DIR__.'/Fixtures/Scenario1');
+        $command->setHelperSet(new HelperSet([new FormatterHelper()]));
+        $tester = new CommandTester($command);
+        $tester->execute([]);
+        $expectedFormat = <<<'OUTPUT'
+%a
+ ---------- ------- ------------ ------%S
+  Variable   Value   .env.local   .env%S
+ ---------- ------- ------------ ------%S
+
+ // Note real values might be different between web and CLI.%S
+%a
+OUTPUT;
+
+        $this->assertStringMatchesFormat($expectedFormat, $tester->getDisplay());
+    }
+
     public function testScenario1InDevEnv()
     {
         $output = $this->executeCommand(__DIR__.'/Fixtures/Scenario1', 'dev');
