minor #37458 Removed comments and requirements relative to php <5.5 (not supported anymore) (lyrixx)

nicolas-grekas · nicolas-grekas · commit 801f4cd7ac0d · 2020-06-30T14:59:42.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- Removed comments and requirements relative to php <5.5 (not supported anymore) | Q | A | ------------- | --- | Branch? | 3.43.43.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | --- There is also https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/EventDispatcher/Tests/AbstractEventDispatcherTest.php#L270-L276 but I think we could let it in place (and this file does not exist on master) Commits ------- 5c5ea75 Removed comments and requirements relative to php <5.5 (not supported anymore)
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -437,8 +437,6 @@ public function setName($name)
      * This feature should be used only when creating a long process command,
      * like a daemon.
      *
-     * PHP 5.5+ or the proctitle PECL library is required
-     *
      * @param string $title The process title
      *
      * @return $this
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToHtml5LocalDateTimeTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToHtml5LocalDateTimeTransformerTest.php
@@ -63,7 +63,6 @@ public function testTransform($fromTz, $toTz, $from, $to)
 
     /**
      * @dataProvider transformProvider
-     * @requires PHP 5.5
      */
     public function testTransformDateTimeImmutable($fromTz, $toTz, $from, $to)
     {
diff --git a/src/Symfony/Component/HttpFoundation/Tests/CookieTest.php b/src/Symfony/Component/HttpFoundation/Tests/CookieTest.php
@@ -115,9 +115,6 @@ public function testConstructorWithDateTime()
         $this->assertEquals($expire->format('U'), $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date');
     }
 
-    /**
-     * @requires PHP 5.5
-     */
     public function testConstructorWithDateTimeImmutable()
     {
         $expire = new \DateTimeImmutable();

Original file line number	Diff line number	Diff line change
`@@ -437,8 +437,6 @@ public function setName($name)`
`437`	`437`	`* This feature should be used only when creating a long process command,`
`438`	`438`	`* like a daemon.`
`439`	`439`	`*`
`440`		`- * PHP 5.5+ or the proctitle PECL library is required`
`441`		`- *`
`442`	`440`	`* @param string $title The process title`
`443`	`441`	`*`
`444`	`442`	`* @return $this`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ public function testTransform($fromTz, $toTz, $from, $to)`
`63`	`63`
`64`	`64`	`/**`
`65`	`65`	`* @dataProvider transformProvider`
`66`		`- * @requires PHP 5.5`
`67`	`66`	`*/`
`68`	`67`	`public function testTransformDateTimeImmutable($fromTz, $toTz, $from, $to)`
`69`	`68`	`{`
Original file line number	Diff line number	Diff line change
`@@ -115,9 +115,6 @@ public function testConstructorWithDateTime()`
`115`	`115`	`$this->assertEquals($expire->format('U'), $cookie->getExpiresTime(), '->getExpiresTime() returns the expire date');`
`116`	`116`	`}`
`117`	`117`
`118`		`- /**`
`119`		`- * @requires PHP 5.5`
`120`		`- */`
`121`	`118`	`public function testConstructorWithDateTimeImmutable()`
`122`	`119`	`{`
`123`	`120`	`$expire = new \DateTimeImmutable();`