Apply (int) casts to safeguard against null values for max-age/s-maxage

mpdude · mpdude · commit 8319c6954254 · 2021-06-14T09:09:01.000Z
diff --git a/src/Symfony/Component/HttpKernel/HttpCache/ResponseCacheStrategy.php b/src/Symfony/Component/HttpKernel/HttpCache/ResponseCacheStrategy.php
@@ -81,8 +81,9 @@ public function add(Response $response)
             return;
         }
 
-        $this->storeRelativeAgeDirective('max-age', $response->headers->getCacheControlDirective('max-age'), $age);
-        $sharedMaxAge = $response->headers->hasCacheControlDirective('s-maxage') ? $response->headers->getCacheControlDirective('s-maxage') : $response->headers->getCacheControlDirective('max-age');
+        $maxAge = $response->headers->hasCacheControlDirective('max-age') ? (int) $response->headers->getCacheControlDirective('max-age') : null;
+        $this->storeRelativeAgeDirective('max-age', $maxAge, $age);
+        $sharedMaxAge = $response->headers->hasCacheControlDirective('s-maxage') ? (int) $response->headers->getCacheControlDirective('s-maxage') : $maxAge;
         $this->storeRelativeAgeDirective('s-maxage', $sharedMaxAge, $age);
 
         $expires = $response->getExpires();
