bug #18629 [Cache] fix expiration handling in ArrayAdapter (xabbuh)

nicolas-grekas · nicolas-grekas · commit 84b48de29985 · 2016-04-25T08:05:55.000+02:00
This PR was merged into the 3.1-dev branch. Discussion ---------- [Cache] fix expiration handling in ArrayAdapter | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 8b0d990 [Cache] fix expiration handling in ArrayAdapter
diff --git a/src/Symfony/Component/Cache/Adapter/ArrayAdapter.php b/src/Symfony/Component/Cache/Adapter/ArrayAdapter.php
@@ -137,6 +137,8 @@ public function save(CacheItemInterface $item)
         $expiry = $item[CacheItem::CAST_PREFIX.'expiry'];
 
         if (null !== $expiry && $expiry <= time()) {
+            $this->deleteItem($key);
+
             return true;
         }
         if ($this->storeSerialized) {

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,8 @@ public function save(CacheItemInterface $item)`
`137`	`137`	`$expiry = $item[CacheItem::CAST_PREFIX.'expiry'];`
`138`	`138`
`139`	`139`	`if (null !== $expiry && $expiry <= time()) {`
	`140`	`+ $this->deleteItem($key);`
	`141`	`+`
`140`	`142`	`return true;`
`141`	`143`	`}`
`142`	`144`	`if ($this->storeSerialized) {`