[EventDispatcher] check for method to exist

xabbuh · xabbuh · commit 84d3f9cfdcf5 · 2016-03-31T19:22:31.000+02:00
diff --git a/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php b/src/Symfony/Component/EventDispatcher/Debug/TraceableEventDispatcher.php
@@ -104,6 +104,10 @@ public function getListeners($eventName = null)
      */
     public function getListenerPriority($eventName, $listener)
     {
+        if (!method_exists($this->dispatcher, 'getListenerPriority')) {
+            throw new \LogicException(sprintf('The wrapped event dispatcher\'s class ("%s") does not implement the getListenerPriority() method.', get_class($this->dispatcher)));
+        }
+
         return $this->dispatcher->getListenerPriority($eventName, $listener);
     }
 
diff --git a/src/Symfony/Component/EventDispatcher/Tests/Debug/TraceableEventDispatcherTest.php b/src/Symfony/Component/EventDispatcher/Tests/Debug/TraceableEventDispatcherTest.php
@@ -73,6 +73,19 @@ public function testGetListenerPriority()
         $this->assertSame(123, $tdispatcher->getListenerPriority('foo', $listeners[0]));
     }
 
+    /**
+     * @expectedException \LogicException
+     */
+    public function testGetListenerPriorityThrowsExceptionWhenWrappedMethodDoesNotExist()
+    {
+        $dispatcher = $this->getMock('Symfony\Component\EventDispatcher\EventDispatcherInterface');
+        $traceableEventDispatcher = new TraceableEventDispatcher($dispatcher, new Stopwatch());
+        $traceableEventDispatcher->addListener('foo', function () {}, 123);
+        $listeners = $traceableEventDispatcher->getListeners('foo');
+
+        $traceableEventDispatcher->getListenerPriority('foo', $listeners[0]);
+    }
+
     public function testAddRemoveSubscriber()
     {
         $dispatcher = new EventDispatcher();

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,10 @@ public function getListeners($eventName = null)`
`104`	`104`	`*/`
`105`	`105`	`public function getListenerPriority($eventName, $listener)`
`106`	`106`	`{`
	`107`	`+ if (!method_exists($this->dispatcher, 'getListenerPriority')) {`
	`108`	`+ throw new \LogicException(sprintf('The wrapped event dispatcher\'s class ("%s") does not implement the getListenerPriority() method.', get_class($this->dispatcher)));`
	`109`	`+ }`
	`110`	`+`
`107`	`111`	`return $this->dispatcher->getListenerPriority($eventName, $listener);`
`108`	`112`	`}`
`109`	`113`