[HttpFoundation] Fixed messed up headers

Bart van den Burg · fabpot · commit 850bd5a06bb5 · 2013-02-26T10:42:13.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php b/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php
@@ -67,6 +67,8 @@ public function __toString()
             $cookies .= 'Set-Cookie: '.$cookie."\r\n";
         }
 
+        ksort($this->headerNames);
+
         return parent::__toString().$cookies;
     }
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php b/src/Symfony/Component/HttpFoundation/Tests/ResponseHeaderBagTest.php
@@ -235,6 +235,20 @@ public function testMakeDisposition($disposition, $filename, $filenameFallback,
         $this->assertEquals($expected, $headers->makeDisposition($disposition, $filename, $filenameFallback));
     }
 
+    public function testToStringDoesntMessUpHeaders()
+    {
+        $headers = new ResponseHeaderBag();
+
+        $headers->set('Location', 'http://www.symfony.com');
+        $headers->set('Content-type', 'text/html');
+
+        (string) $headers;
+
+        $allHeaders = $headers->allPreserveCase();
+        $this->assertEquals(array('http://www.symfony.com'), $allHeaders['Location']);
+        $this->assertEquals(array('text/html'), $allHeaders['Content-type']);
+    }
+
     public function provideMakeDisposition()
     {
         return array(

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,8 @@ public function __toString()`
`67`	`67`	`$cookies .= 'Set-Cookie: '.$cookie."\r\n";`
`68`	`68`	`}`
`69`	`69`
	`70`	`+ ksort($this->headerNames);`
	`71`	`+`
`70`	`72`	`return parent::__toString().$cookies;`
`71`	`73`	`}`
`72`	`74`