add legacy tag to EntityTypeTest - edit upgrade/changelog

bamarni · bamarni · commit 867d8e982473 · 2016-02-02T19:12:45.000+01:00
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -14,6 +14,44 @@ Form
 
  * The `choices_as_values` option of the `ChoiceType` has been removed.
 
+ * The `expanded` option of the `ChoiceType` has been removed.
+   Use instead the `widget` option with `select`, `checkbox`, `radio`, `text` or `hidden`.
+
+   Before:
+
+   ```php
+   use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
+
+   $form = $this->createFormBuilder()
+      ->add('isAttending', ChoiceType::class, array(
+         'choices'  => array(
+            'Maybe' => null,
+            'Yes' => true,
+            'No' => false,
+         ),
+         'expanded' => true,
+         'multiple' => true,
+      ))
+      ->getForm();
+   ```
+
+   After:
+
+   ```php
+   use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
+
+   $form = $this->createFormBuilder()
+      ->add('isAttending', ChoiceType::class, array(
+         'choices'  => array(
+            'Maybe' => null,
+            'Yes' => true,
+            'No' => false,
+         ),
+         'widget' => 'checkbox',
+      ))
+      ->getForm();
+   ```
+
 Serializer
 ----------
 
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php b/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php
@@ -34,6 +34,9 @@
 use Symfony\Bridge\Doctrine\Tests\Fixtures\SingleAssociationToIntIdEntity;
 use Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIntIdNoToStringEntity;
 
+/**
+ * @group legacy
+ */
 class EntityTypeTest extends TypeTestCase
 {
     const ITEM_GROUP_CLASS = 'Symfony\Bridge\Doctrine\Tests\Fixtures\GroupableEntity';
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 -----
 
  * deprecated the "choices_as_values" option of ChoiceType
+ * deprecated the "expanded" option of ChoiceType
 
 3.0.0
 -----

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,9 @@`
`34`	`34`	`use Symfony\Bridge\Doctrine\Tests\Fixtures\SingleAssociationToIntIdEntity;`
`35`	`35`	`use Symfony\Bridge\Doctrine\Tests\Fixtures\SingleIntIdNoToStringEntity;`
`36`	`36`
	`37`	`+/**`
	`38`	`+ * @group legacy`
	`39`	`+ */`
`37`	`40`	`class EntityTypeTest extends TypeTestCase`
`38`	`41`	`{`
`39`	`42`	`const ITEM_GROUP_CLASS = 'Symfony\Bridge\Doctrine\Tests\Fixtures\GroupableEntity';`