Fix review

vincentchalamon · vincentchalamon · commit 86ab25586da2 · 2023-05-30T16:42:27.000+02:00
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcUserInfoTokenHandlerFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/AccessToken/OidcUserInfoTokenHandlerFactory.php
@@ -60,10 +60,12 @@ public function addConfiguration(NodeBuilder $node): void
                     ->scalarNode('base_uri')
                         ->info('Base URI of the userinfo endpoint on the OIDC server.')
                         ->isRequired()
+                        ->cannotBeEmpty()
                     ->end()
                     ->scalarNode('claim')
                         ->info('Claim which contains the user identifier (e.g. sub, email, etc.).')
                         ->defaultValue('sub')
+                        ->cannotBeEmpty()
                     ->end()
                     ->scalarNode('client')
                         ->info('HttpClient service id to use to call the OIDC server.')
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Security/Factory/AccessTokenFactoryTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/Security/Factory/AccessTokenFactoryTest.php
@@ -129,7 +129,7 @@ public function testOidcUserInfoTokenHandlerConfigurationWithBaseUri(array|strin
         $this->assertEquals($expected, $container->getDefinition('security.access_token_handler.firewall1')->getArguments());
     }
 
-    public function getOidcUserInfoConfiguration(): iterable
+    public static function getOidcUserInfoConfiguration(): iterable
     {
         yield [['base_uri' => 'https://www.example.com/realms/demo/protocol/openid-connect/userinfo']];
         yield ['https://www.example.com/realms/demo/protocol/openid-connect/userinfo'];

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ public function testOidcUserInfoTokenHandlerConfigurationWithBaseUri(array\|strin`
`129`	`129`	`$this->assertEquals($expected, $container->getDefinition('security.access_token_handler.firewall1')->getArguments());`
`130`	`130`	`}`
`131`	`131`
`132`		`- public function getOidcUserInfoConfiguration(): iterable`
	`132`	`+ public static function getOidcUserInfoConfiguration(): iterable`
`133`	`133`	`{`
`134`	`134`	`yield [['base_uri' => 'https://www.example.com/realms/demo/protocol/openid-connect/userinfo']];`
`135`	`135`	`yield ['https://www.example.com/realms/demo/protocol/openid-connect/userinfo'];`