[PropertyInfo] Add failing test case for multi phpdoc covered promoted properties

ostrolucky · ostrolucky · commit 878b6ce3432d · 2022-06-02T00:18:04.000+02:00
This demonstrates that #46056 causes a regression and incorrectly detects types in case there are multiple phpdoc covered promoted properties.
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTestDoc.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTestDoc.php
@@ -467,6 +467,7 @@ public function php80TypesProvider()
         return [
             [Php80Dummy::class, 'promotedAndMutated', [new Type(Type::BUILTIN_TYPE_STRING)]],
             [Php80Dummy::class, 'promoted', null],
+            [Php80Dummy::class, 'collection', [new Type(Type::BUILTIN_TYPE_ARRAY, collection: true, collectionValueType: new Type(Type::BUILTIN_TYPE_STRING))]],
             [Php80PromotedDummy::class, 'promoted', null],
         ];
     }
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Php80Dummy.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Php80Dummy.php
@@ -17,8 +17,9 @@ class Php80Dummy
 
     /**
      * @param string $promotedAndMutated
+     * @param array<string> $collection
      */
-    public function __construct(private mixed $promoted, private mixed $promotedAndMutated)
+    public function __construct(private mixed $promoted, private mixed $promotedAndMutated, private array $collection)
     {
     }
 

Original file line number	Diff line number	Diff line change
`@@ -467,6 +467,7 @@ public function php80TypesProvider()`
`467`	`467`	`return [`
`468`	`468`	`[Php80Dummy::class, 'promotedAndMutated', [new Type(Type::BUILTIN_TYPE_STRING)]],`
`469`	`469`	`[Php80Dummy::class, 'promoted', null],`
	`470`	`+ [Php80Dummy::class, 'collection', [new Type(Type::BUILTIN_TYPE_ARRAY, collection: true, collectionValueType: new Type(Type::BUILTIN_TYPE_STRING))]],`
`470`	`471`	`[Php80PromotedDummy::class, 'promoted', null],`
`471`	`472`	`];`
`472`	`473`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,9 @@ class Php80Dummy`
`17`	`17`
`18`	`18`	`/**`
`19`	`19`	`* @param string $promotedAndMutated`
	`20`	`+ * @param array<string> $collection`
`20`	`21`	`*/`
`21`		`- public function __construct(private mixed $promoted, private mixed $promotedAndMutated)`
	`22`	`+ public function __construct(private mixed $promoted, private mixed $promotedAndMutated, private array $collection)`
`22`	`23`	`{`
`23`	`24`	`}`
`24`	`25`