Merge branch '2.2' into 2.3

fabpot · fabpot · commit 8899e31a88a1 · 2013-09-12T22:07:23.000+02:00
* 2.2: [HttpFoundation] removed double-slashes (closes #8388) [HttpFoundation] tried to keep the original Request URI as much as possible to avoid different behavior between ::createFromGlobals() and ::create() [TwigBridge] fixed form rendering when used in a template with dynamic inheritance
diff --git a/src/Symfony/Bridge/Twig/Form/TwigRendererEngine.php b/src/Symfony/Bridge/Twig/Form/TwigRendererEngine.php
@@ -167,6 +167,8 @@ protected function loadResourcesFromTheme($cacheKey, &$theme)
         // theme is a reference and we don't want to change it.
         $currentTheme = $theme;
 
+        $context = $this->environment->mergeGlobals(array());
+
         // The do loop takes care of template inheritance.
         // Add blocks from all templates in the inheritance tree, but avoid
         // overriding blocks already set.
@@ -178,6 +180,6 @@ protected function loadResourcesFromTheme($cacheKey, &$theme)
                     $this->resources[$cacheKey][$block] = $blockData;
                 }
             }
-        } while (false !== $currentTheme = $currentTheme->getParent(array()));
+        } while (false !== $currentTheme = $currentTheme->getParent($context));
     }
 }
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/FormExtensionDivLayoutTest.php b/src/Symfony/Bridge/Twig/Tests/Extension/FormExtensionDivLayoutTest.php
@@ -64,6 +64,8 @@ protected function setUp()
         $environment = new \Twig_Environment($loader, array('strict_variables' => true));
         $environment->addExtension(new TranslationExtension(new StubTranslator()));
         $environment->addGlobal('global', '');
+        // the value can be any template that exists
+        $environment->addGlobal('dynamic_template_name', 'child_label');
         $environment->addExtension($this->extension);
 
         $this->extension->initRuntime($environment);
@@ -106,6 +108,18 @@ public function testThemeBlockInheritanceUsingExtend()
         );
     }
 
+    public function testThemeBlockInheritanceUsingDynamicExtend()
+    {
+        $view = $this->factory
+            ->createNamed('name', 'email')
+            ->createView()
+        ;
+
+        $renderer = $this->extension->renderer;
+        $renderer->setTheme($view, array('page_dynamic_extends.html.twig'));
+        $renderer->searchAndRenderBlock($view, 'row');
+    }
+
     public function isSelectedChoiceProvider()
     {
         // The commented cases should not be necessary anymore, because the
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/page_dynamic_extends.html.twig b/src/Symfony/Bridge/Twig/Tests/Extension/page_dynamic_extends.html.twig
@@ -0,0 +1 @@
+{% extends dynamic_template_name ~ '.html.twig' %}
diff --git a/src/Symfony/Component/HttpFoundation/File/File.php b/src/Symfony/Component/HttpFoundation/File/File.php
@@ -137,7 +137,7 @@ protected function getTargetFile($directory, $name = null)
             throw new FileException(sprintf('Unable to write in the "%s" directory', $directory));
         }
 
-        $target = $directory.DIRECTORY_SEPARATOR.(null === $name ? $this->getBasename() : $this->getName($name));
+        $target = trim($directory, '/\\').DIRECTORY_SEPARATOR.(null === $name ? $this->getBasename() : $this->getName($name));
 
         return new File($target, false);
     }
diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -346,11 +346,20 @@ public static function create($uri, $method = 'GET', $parameters = array(), $coo
                 break;
         }
 
+        $queryString = '';
         if (isset($components['query'])) {
             parse_str(html_entity_decode($components['query']), $qs);
-            $query = array_replace($qs, $query);
+
+            if ($query) {
+                $query = array_replace($qs, $query);
+                $queryString = http_build_query($query, '', '&');
+            } else {
+                $query = $qs;
+                $queryString = $components['query'];
+            }
+        } elseif ($query) {
+            $queryString = http_build_query($query, '', '&');
         }
-        $queryString = http_build_query($query, '', '&');
 
         $server['REQUEST_URI'] = $components['path'].('' !== $queryString ? '?'.$queryString : '');
         $server['QUERY_STRING'] = $queryString;
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php b/src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
@@ -211,6 +211,10 @@ public function testCreate()
         $this->assertEquals('testnopass', $request->getUser());
         $this->assertNull($request->getPassword());
         $this->assertFalse($request->isSecure());
+
+        $request = Request::create('http://test.com/?foo');
+        $this->assertEquals('/?foo', $request->getRequestUri());
+        $this->assertEquals(array('foo' => ''), $request->query->all());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -167,6 +167,8 @@ protected function loadResourcesFromTheme($cacheKey, &$theme)`
`167`	`167`	`// theme is a reference and we don't want to change it.`
`168`	`168`	`$currentTheme = $theme;`
`169`	`169`
	`170`	`+ $context = $this->environment->mergeGlobals(array());`
	`171`	`+`
`170`	`172`	`// The do loop takes care of template inheritance.`
`171`	`173`	`// Add blocks from all templates in the inheritance tree, but avoid`
`172`	`174`	`// overriding blocks already set.`
`@@ -178,6 +180,6 @@ protected function loadResourcesFromTheme($cacheKey, &$theme)`
`178`	`180`	`$this->resources[$cacheKey][$block] = $blockData;`
`179`	`181`	`}`
`180`	`182`	`}`
`181`		`- } while (false !== $currentTheme = $currentTheme->getParent(array()));`
	`183`	`+ } while (false !== $currentTheme = $currentTheme->getParent($context));`
`182`	`184`	`}`
`183`	`185`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+{% extends dynamic_template_name ~ '.html.twig' %}`
Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ protected function getTargetFile($directory, $name = null)`
`137`	`137`	`throw new FileException(sprintf('Unable to write in the "%s" directory', $directory));`
`138`	`138`	`}`
`139`	`139`
`140`		`- $target = $directory.DIRECTORY_SEPARATOR.(null === $name ? $this->getBasename() : $this->getName($name));`
	`140`	`+ $target = trim($directory, '/\\').DIRECTORY_SEPARATOR.(null === $name ? $this->getBasename() : $this->getName($name));`
`141`	`141`
`142`	`142`	`return new File($target, false);`
`143`	`143`	`}`