[WebServerBundle] Added ability to display the current hostname address if available when binding to 0.0.0.0

respinoza · respinoza · commit 88b2ad26abca · 2018-09-25T00:12:37.000+09:00
diff --git a/src/Symfony/Bundle/WebServerBundle/CHANGELOG.md b/src/Symfony/Bundle/WebServerBundle/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.2.0
+-----
+
+ * Added ability to display the current hostname address if available when binding to 0.0.0.0
+
 3.4.0
 -----
 
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerRunCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerRunCommand.php
@@ -132,7 +132,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $server = new WebServer();
             $config = new WebServerConfig($documentRoot, $env, $input->getArgument('addressport'), $input->getOption('router'));
 
-            $io->success(sprintf('Server listening on http://%s', $config->getAddress()));
+            $message = sprintf('Server listening on http://%s', $config->getAddress());
+            if ('' !== $extra = $config->getExtraAddress()) {
+                $message = sprintf('%s (http://%s)', $message, $extra);
+            }
+            $io->success($message);
             if (ini_get('xdebug.profiler_enable_trigger')) {
                 $io->comment('Xdebug profiler trigger enabled.');
             }
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php
@@ -143,7 +143,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $config = new WebServerConfig($documentRoot, $env, $input->getArgument('addressport'), $input->getOption('router'));
 
             if (WebServer::STARTED === $server->start($config, $input->getOption('pidfile'))) {
-                $io->success(sprintf('Server listening on http://%s', $config->getAddress()));
+                $message = sprintf('Server listening on http://%s', $config->getAddress());
+                if ('' !== $extra = $config->getExtraAddress()) {
+                    $message = sprintf('%s (http://%s)', $message, $extra);
+                }
+                $io->success($message);
                 if (ini_get('xdebug.profiler_enable_trigger')) {
                     $io->comment('Xdebug profiler trigger enabled.');
                 }
diff --git a/src/Symfony/Bundle/WebServerBundle/WebServerConfig.php b/src/Symfony/Bundle/WebServerBundle/WebServerConfig.php
@@ -101,6 +101,22 @@ public function getAddress()
         return $this->hostname.':'.$this->port;
     }
 
+    /**
+     * @return string contains resolved hostname if available, empty string otherwise
+     */
+    public function getExtraAddress()
+    {
+        if ('0.0.0.0' !== $this->hostname) {
+            return '';
+        }
+
+        if (false === $localHostname = gethostname()) {
+            return '';
+        }
+
+        return gethostbyname($localHostname).':'.$this->port;
+    }
+
     private function findFrontController($documentRoot, $env)
     {
         $fileNames = $this->getFrontControllerFileNames($env);
