bug #39244 [String] Fix Notice when argument is empty string (moldman)

derrabus · derrabus · commit 88cbcf99c0c5 · 2020-12-01T18:07:21.000+01:00
This PR was merged into the 5.1 branch. Discussion ---------- [String] Fix Notice when argument is empty string | Q | A | ------------- | --- | Branch? | 5.1  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | License | MIT PHP Notice is generated when we pass empty string to `singularize` or `pluralize` method. ``` $inflector = new \Symfony\Component\String\Inflector\EnglishInflector(); $inflector->singularize(''); ``` ``` Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 PHP Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 ``` ``` $inflector = new \Symfony\Component\String\Inflector\EnglishInflector(); $inflector->pluralize(''); ``` ``` Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 424 PHP Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 424 ``` **Background**: When `\Symfony\Component\PropertyAccess\PropertyAccessorInterface::setValue` is used with `_` property, then it calls \Symfony\Component\String\Inflector\EnglishInflector::singularize with empty string. ``` class Check { public $_; } $check = new Check(); $pr = PropertyAccess::createPropertyAccessorBuilder() ->getPropertyAccessor(); if($pr->isWritable($check, '_')){ $pr->setValue($check, '_', 'test'); } var_dump($check); ``` ``` Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 PHP Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 ... Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 PHP Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 Notice: Uninitialized string offset: 0 in vendor/symfony/string/Inflector/EnglishInflector.php on line 344 object(Check)#6 (1) { ["_"]=> string(4) "test" } ``` P.S. Another solution is to include empty string in \Symfony\Component\String\Inflector\EnglishInflector::$uninflected ``` private static $uninflected = [ '', 'atad', 'reed', 'kcabdeef', 'hsif', 'ofni', 'esoom', 'seires', 'peehs', 'seiceps', ]; ``` If this PR is not relevant please close and sorry for inconvenience. Commits ------- 88c2b9b [String] Fix Notice when argument is empty string
diff --git a/src/Symfony/Component/String/Inflector/EnglishInflector.php b/src/Symfony/Component/String/Inflector/EnglishInflector.php
@@ -305,6 +305,7 @@ final class EnglishInflector implements InflectorInterface
      * A list of words which should not be inflected, reversed.
      */
     private static $uninflected = [
+        '',
         'atad',
         'reed',
         'kcabdeef',
diff --git a/src/Symfony/Component/String/Tests/EnglishInflectorTest.php b/src/Symfony/Component/String/Tests/EnglishInflectorTest.php
@@ -306,4 +306,16 @@ public function testPluralize(string $singular, $plural)
     {
         $this->assertSame(\is_array($plural) ? $plural : [$plural], (new EnglishInflector())->pluralize($singular));
     }
+
+    public function testPluralizeEmptyString()
+    {
+        $plural = (new EnglishInflector())->pluralize('');
+        $this->assertSame([''], $plural);
+    }
+
+    public function testSingularizeEmptyString()
+    {
+        $singular = (new EnglishInflector())->singularize('');
+        $this->assertSame([''], $singular);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -306,4 +306,16 @@ public function testPluralize(string $singular, $plural)`
`306`	`306`	`{`
`307`	`307`	`$this->assertSame(\is_array($plural) ? $plural : [$plural], (new EnglishInflector())->pluralize($singular));`
`308`	`308`	`}`
	`309`	`+`
	`310`	`+ public function testPluralizeEmptyString()`
	`311`	`+ {`
	`312`	`+ $plural = (new EnglishInflector())->pluralize('');`
	`313`	`+ $this->assertSame([''], $plural);`
	`314`	`+ }`
	`315`	`+`
	`316`	`+ public function testSingularizeEmptyString()`
	`317`	`+ {`
	`318`	`+ $singular = (new EnglishInflector())->singularize('');`
	`319`	`+ $this->assertSame([''], $singular);`
	`320`	`+ }`
`309`	`321`	`}`