[Translation][File dumper] allow get file content without writing in file.

aitboudad · aitboudad · commit 8969df2df707 · 2015-09-14T08:57:28.000Z
diff --git a/src/Symfony/Component/Translation/Dumper/FileDumper.php b/src/Symfony/Component/Translation/Dumper/FileDumper.php
@@ -63,26 +63,34 @@ public function setBackup($backup)
      */
     public function dump(MessageCatalogue $messages, $options = array())
     {
-        if (!array_key_exists('path', $options)) {
-            throw new \InvalidArgumentException('The file dumper needs a path option.');
+        if (!array_key_exists('path', $options) && !array_key_exists('format_callback', $options)) {
+            throw new \InvalidArgumentException('The file dumper needs a path or format_callback option.');
         }
 
         // save a file for each domain
         foreach ($messages->getDomains() as $domain) {
-            // backup
-            $fullpath = $options['path'].'/'.$this->getRelativePath($domain, $messages->getLocale());
-            if (file_exists($fullpath)) {
-                if ($this->backup) {
-                    copy($fullpath, $fullpath.'~');
-                }
-            } else {
-                $directory = dirname($fullpath);
-                if (!file_exists($directory) && !@mkdir($directory, 0777, true)) {
-                    throw new \RuntimeException(sprintf('Unable to create directory "%s".', $directory));
+            $content = $this->formatCatalogue($messages, $domain, $options);
+            if (array_key_exists('path', $options)) {
+                // backup
+                $fullpath = $options['path'].'/'.$this->getRelativePath($domain, $messages->getLocale());
+                if (file_exists($fullpath)) {
+                    if ($this->backup) {
+                        copy($fullpath, $fullpath.'~');
+                    }
+                } else {
+                    $directory = dirname($fullpath);
+                    if (!file_exists($directory) && !@mkdir($directory, 0777, true)) {
+                        throw new \RuntimeException(sprintf('Unable to create directory "%s".', $directory));
+                    }
                 }
+
+                // save file
+                file_put_contents($fullpath, $content);
+            }
+
+            if (array_key_exists('format_callback', $options) && is_callable($options['format_callback'])) {
+                call_user_func($options['format_callback'], $content);
             }
-            // save file
-            file_put_contents($fullpath, $this->formatCatalogue($messages, $domain, $options));
         }
     }
 
diff --git a/src/Symfony/Component/Translation/Tests/Dumper/FileDumperTest.php b/src/Symfony/Component/Translation/Tests/Dumper/FileDumperTest.php
@@ -16,6 +16,20 @@
 
 class FileDumperTest extends \PHPUnit_Framework_TestCase
 {
+    public function testDumpWithFormatCallback()
+    {
+        $catalogue = new MessageCatalogue('en');
+        $catalogue->add(array('foo' => 'bar'));
+
+        $dumper = new ConcreteFileDumper();
+        $format = false;
+        $dumper->dump($catalogue, array('format_callback' => function ($content) use (&$format) {
+            $format = true;
+        }));
+
+        $this->assertTrue($format);
+    }
+
     public function testDumpBackupsFileIfExisting()
     {
         $tempDir = sys_get_temp_dir();
